-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Localization: Overhaul Localizable Content + Normalize Specific Expressions in Settings + Refined Chinese Localization #303
Conversation
handsome |
🫡👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! It clearly looks like you've put a lot of work into this 🤩
I have requested a few changes, but then this should be ready for merge!
In addition, I don't speak Chinese at all but, I have noticed that you put some periods (。) in certain options, while others do not. Most notably:
Just making sure that these were intentional?
Thank you very much for your contributions :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you so much again! I really appreciate it! 🥳
@zXiaoyuLuo It has not yet been released as a version. It is something I hope to do soon, but I have been busy fixing bugs and adding new features at the moment 😉 |
whether it means that i should delete it and re-download it on my macbook? |
You can download a test build here.
Please make a new issue for this so that I can track it :) |
@KrLite “中键”的“键”译错了😀A wrong translation of "键". |
Hi there!
I'm really fascinated by the app you made, hence I want to contribute to make it more accessible and user friendly by adding localizations and fixing some inappropriate content expressions.
I hereby explain what I actually did in the pull request:
1. Normalize Expressions
MacOS
in texts tomacOS
since the latter is the official name.Github
in texts toGitHub
since the latter is the official name.2. Expand Localization Reach
Loop
) to dynamic formats like\(Bundle.main.appName)
.3. Chinese Localization
Screenshots with Chinese Localizations
Conclusion
I'm always passionate to contribute to amazing open source projects. I hope my pull request helps simplify future localization workflows and convenience users in more regions. I would greatly appreciate if this request could be merged!
Please contact me if there are any issues.