Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woptim] update spack + update to rocm 5.7.1 #245

Merged
merged 29 commits into from
Mar 4, 2024
Merged

Conversation

adrienbernede
Copy link
Member

@adrienbernede adrienbernede commented Feb 14, 2024

Next steps are, in my opinion:

  1. Merge Use new macros for BLT TPL exports Umpire#857 -> done, we are now testing CHAI with umpire@develop ~= [email protected]
  2. Fix issues mentioned in [Woptim] [DO NOT MERGE] test umpire #857 #246 and now appearing in this PR. @adayton1
  3. Merge the present PR.
  4. Merge Update to BLT v0.6.1 #243

@adayton1 @rhornung67, you both have created PRs in RADIUSS Spack Configs related to the 2024.02.0 releases. Both have different goals, Rich’s one (LLNL/radiuss-spack-configs#90) aims to add the release to the packages, while Alan’s one (LLNL/radiuss-spack-configs#89) aims to test CHAI with RAJA, Umpire and BLT at their release state.

I gathered those changes with mine and Chris White’s ones in a single, coherent, branch.

This branch is tested and vetted here.

@adrienbernede adrienbernede mentioned this pull request Feb 14, 2024
rhornung67
rhornung67 previously approved these changes Feb 14, 2024
@adayton1
Copy link
Member

@adrienbernede, I think this merge request will need to go in next. Can you get it up to date with develop, or would you like me to handle the merge conflicts?

@adrienbernede
Copy link
Member Author

adrienbernede commented Mar 4, 2024

@adayton1 could you please give a look at the failing job on lassen ?

@adayton1
Copy link
Member

adayton1 commented Mar 4, 2024

@adayton1 could you please give a look at the failing job on lassen ?

There seems to be a bad interplay with fmt coming through umpire and libcpp. RAJA and Umpire do not build with libcpp, so I made a change to allow failure for that test. I also disabled the failing docker test since Umpire and RAJA have that turned off as well. So I think if you merge in develop, I think all the tests should pass.

Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrienbernede
Copy link
Member Author

@adayton1 I got the CI green, however Umpire does build with libcpp: https://lc.llnl.gov/gitlab/radiuss/Umpire/-/jobs/1720331
I think there is something to be understood about the libcpp job that is related to CHAI.

@adayton1
Copy link
Member

adayton1 commented Mar 4, 2024

@adayton1 I got the CI green, however Umpire does build with libcpp: https://lc.llnl.gov/gitlab/radiuss/Umpire/-/jobs/1720331 I think there is something to be understood about the libcpp job that is related to CHAI.

OK, I'm making a note to revisit the libcpp job.

@adayton1 adayton1 merged commit 743434c into develop Mar 4, 2024
19 checks passed
adayton1 added a commit that referenced this pull request Mar 5, 2024
* Depend on develop version of TPLs

* Tweak version constraints

* Update Umpire package

* Fix syntax error in Umpire package

* Update packages for CHAI and Umpire

* Depend on newer camp

* Update versions for RAJA and Umpire

* Fixes for libcpp builds

* Add SLURM_OVERLAP variable

* Add greater control for when CHAI is a submodule

* Fix hip build with resource manager disabled

* Depend on camp@main

* Missed one reference to camp@master

* Bug fixes for HIP and managed_ptr

* Clean up managed_ptr.hpp

* Fix host build warning

* Customize block size for HIP build

* Add a managed_ptr example

* Fix HIP kernel launches

* Add reproducer for HIP managed_ptr errors

* Clean up managed_ptr reproducer

* Add a simpler reproducer

* Add simplest reproducer

* Fix macro

* Fix mutex lock in evict() that overlaps with lock in free()

* initial changes to add CHAI_ cmake prefix

* fixing cmake option command syntax

* trying to fix azure pipeline image and raja plugin flag

* make edits to azure pipeline file

* Switching from quartz to ruby in gitlab CI

* Updating umpire camp dependency

* Release v2022.03.0 (#208)

* Update Spack packages for CI (#210)

* Add CHAI + RAJA launch integration test. (#219)

* Release v2022.10.0 (#217)

* Make operator overloads bind in more cases (#222)

* MigrateInner on CHAI Copyable for PINNED / UM (#223)

* Use shared CI (#213)

* Deprecate API for synchronization after device kernels (#228)

* setExecutionSpace thread safety(#230)


Co-authored-by: Neela Kausik <[email protected]>

* Release v2023.06.0 (#232)

* [Woptim] Update shared ci to v2023.08.0 (#236)

* Remove explicit device synchronization (#235)

* Update radiuss-shared-ci to new release (with radiuss-spack-configs) (#238)

* Use free instead of realloc to zero size (#239)

* [Woptim] shared ci 2023.12.0 (#241)

* Update Shared CI and Spack Configs to add poodle

* Activate poodle subpipeline

* Reduce allocated time

* Fine tune allocation duration

* Fine tune allocation duration in CI

* Comment alloc command choices

* Update RSC to main

* Fix missing poodle alloc info, update to radiuss Shared CI 2023.12.0, sync build_and_test script with RAJA

* Update radiuss-spack-configs

* CI updates (#244)

* Updates radiuss-spack-configs to commit a37c3e1
* Changes to match the CI of other projects

* Support for a single memory space writeable by both GPU and CPU (#242)

* Support for a single memory space writeable by both GPU and CPU. Provides appropriate synchronizations when needed instead of performing any memory copies.

---------

Co-authored-by: Alan Dayton <[email protected]>

* Clean up CHAI dependency handling

* Revert "Clean up CHAI dependency handling"

This reverts commit 5afb66a.

* Clean up CMake in CHAI (#247)

* Update copyright to 2024 (#248)

* Update to BLT v0.6.1 (#243)

* Update to BLT v0.6.1
* Update to RAJA v2024.02.0
* Update to Umpire 2024.02.0
* Use new way of exporting tpls
* Disable failing container builds since container images are being revamped
* Allow failure for the job using libcpp - doesn't play nicely with fmt at the moment
* Use branch of radiuss-spack-configs to fix spack builds
* Add install tests
* Add a file with release notes
* Ignoring runner issues on tioga since the jobs passed previously

* [Woptim] update spack + update to rocm 5.7.1 (#245)

* Update Spack version
* Update RADIUSS Spack Configs with February 2024 release changes

---------

Co-authored-by: Alan Dayton <[email protected]>

* Update version numbers

---------

Co-authored-by: David Beckingsale <[email protected]>
Co-authored-by: Benjamin T. Liu <[email protected]>
Co-authored-by: Kristi <[email protected]>
Co-authored-by: Kristi <[email protected]>
Co-authored-by: Arturo Vargas <[email protected]>
Co-authored-by: robinson96 <[email protected]>
Co-authored-by: Adrien Bernede <[email protected]>
Co-authored-by: Neela Kausik <[email protected]>
Co-authored-by: Ben Liu <[email protected]>
@adrienbernede adrienbernede deleted the woptim/rocm-5-7-1 branch November 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants