Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to BLT v0.6.1 #243

Merged
merged 31 commits into from
Mar 4, 2024
Merged

Update to BLT v0.6.1 #243

merged 31 commits into from
Mar 4, 2024

Conversation

adayton1
Copy link
Member

Update to BLT v0.6.1

@davidbeckingsale
Copy link
Member

Could you add the target export feature, see: LLNL/RAJA#1542 and LLNL/Umpire#857

@adayton1
Copy link
Member Author

Could you add the target export feature, see: LLNL/RAJA#1542 and LLNL/Umpire#857

Done.

rhornung67
rhornung67 previously approved these changes Feb 13, 2024
@davidbeckingsale
Copy link
Member

We don't have robust testing for this, but I'm concerned that the chai-config might need to also find raja/umpire/camp.

I can add a test next week once I'm back, or if you want to take a crack this week, take a look at 'install-test' in Umpire/RAJA as an example: https://github.com/LLNL/Umpire/tree/develop/tests/install and https://github.com/LLNL/Umpire/blob/develop/scripts/gitlab/build_and_test.sh#L222-L235

@adrienbernede adrienbernede mentioned this pull request Feb 14, 2024
@adayton1
Copy link
Member Author

@adrienbernede, @rhornung67, I think there are a couple of prerequisites before this can be merged in.

I think we need the newer radiuss-spack-configs to get the latest version of BLT anyway - the commit we just moved to does not have 0.6.1.

If you can think of a better way to do this, I'm open to hearing other ideas as well. I just don't want to have to hardcode the BLT version for every job and then undo that change after the release.

An alternative approach is to create local spack packages for just blt and chai, point to that first, then point to radiuss-spack-configs (I believe there is a way to pull from multiple spack repos). Then radiuss-spack-configs could be updated after the release of CHAI.

@adayton1
Copy link
Member Author

Also, there's still some trouble with the Docker hip build and I know nothing about Docker. I think Umpire was having the same problem.

@rhornung67
Copy link
Member

@adayton1 two things...first, the Docker HIP build is using 4.3.1 version of the compiler so a newer version may be better. second, it looks like the CMake is using the syntax blt_hip. i think it's supposed to be blt::hip now.

@adayton1
Copy link
Member Author

adayton1 commented Feb 14, 2024

@adayton1 two things...first, the Docker HIP build is using 4.3.1 version of the compiler so a newer version may be better. second, it looks like the CMake is using the syntax blt_hip. i think it's supposed to be blt::hip now.

It looks like the latest available image from that repo is 5.1.3, so I'll try that. I grepped for blt_hip in chai and all its submodules, and it's not used anywhere. I'm really confused about where it is coming from.

I just checked in RAJA and the Docker hip job is commented out haha.

@adayton1
Copy link
Member Author

We don't have robust testing for this, but I'm concerned that the chai-config might need to also find raja/umpire/camp.

I can add a test next week once I'm back, or if you want to take a crack this week, take a look at 'install-test' in Umpire/RAJA as an example: https://github.com/LLNL/Umpire/tree/develop/tests/install and https://github.com/LLNL/Umpire/blob/develop/scripts/gitlab/build_and_test.sh#L222-L235

I updated chai-config.cmake to have find_dependency calls for Umpire and RAJA, as well as a bunch of other CMake clean up.

I'll take a look at setting up install testing as well.

@rhornung67
Copy link
Member

@adayton1 Chris or David may have some insight into what is going awry with the Docker container.

@adayton1 adayton1 merged commit bb0a968 into develop Mar 4, 2024
16 of 19 checks passed
@adayton1 adayton1 deleted the feature/dayton8/blt_0_6_1 branch March 4, 2024 17:25
@adayton1 adayton1 mentioned this pull request Mar 4, 2024
adayton1 added a commit that referenced this pull request Mar 5, 2024
* Depend on develop version of TPLs

* Tweak version constraints

* Update Umpire package

* Fix syntax error in Umpire package

* Update packages for CHAI and Umpire

* Depend on newer camp

* Update versions for RAJA and Umpire

* Fixes for libcpp builds

* Add SLURM_OVERLAP variable

* Add greater control for when CHAI is a submodule

* Fix hip build with resource manager disabled

* Depend on camp@main

* Missed one reference to camp@master

* Bug fixes for HIP and managed_ptr

* Clean up managed_ptr.hpp

* Fix host build warning

* Customize block size for HIP build

* Add a managed_ptr example

* Fix HIP kernel launches

* Add reproducer for HIP managed_ptr errors

* Clean up managed_ptr reproducer

* Add a simpler reproducer

* Add simplest reproducer

* Fix macro

* Fix mutex lock in evict() that overlaps with lock in free()

* initial changes to add CHAI_ cmake prefix

* fixing cmake option command syntax

* trying to fix azure pipeline image and raja plugin flag

* make edits to azure pipeline file

* Switching from quartz to ruby in gitlab CI

* Updating umpire camp dependency

* Release v2022.03.0 (#208)

* Update Spack packages for CI (#210)

* Add CHAI + RAJA launch integration test. (#219)

* Release v2022.10.0 (#217)

* Make operator overloads bind in more cases (#222)

* MigrateInner on CHAI Copyable for PINNED / UM (#223)

* Use shared CI (#213)

* Deprecate API for synchronization after device kernels (#228)

* setExecutionSpace thread safety(#230)


Co-authored-by: Neela Kausik <[email protected]>

* Release v2023.06.0 (#232)

* [Woptim] Update shared ci to v2023.08.0 (#236)

* Remove explicit device synchronization (#235)

* Update radiuss-shared-ci to new release (with radiuss-spack-configs) (#238)

* Use free instead of realloc to zero size (#239)

* [Woptim] shared ci 2023.12.0 (#241)

* Update Shared CI and Spack Configs to add poodle

* Activate poodle subpipeline

* Reduce allocated time

* Fine tune allocation duration

* Fine tune allocation duration in CI

* Comment alloc command choices

* Update RSC to main

* Fix missing poodle alloc info, update to radiuss Shared CI 2023.12.0, sync build_and_test script with RAJA

* Update radiuss-spack-configs

* CI updates (#244)

* Updates radiuss-spack-configs to commit a37c3e1
* Changes to match the CI of other projects

* Support for a single memory space writeable by both GPU and CPU (#242)

* Support for a single memory space writeable by both GPU and CPU. Provides appropriate synchronizations when needed instead of performing any memory copies.

---------

Co-authored-by: Alan Dayton <[email protected]>

* Clean up CHAI dependency handling

* Revert "Clean up CHAI dependency handling"

This reverts commit 5afb66a.

* Clean up CMake in CHAI (#247)

* Update copyright to 2024 (#248)

* Update to BLT v0.6.1 (#243)

* Update to BLT v0.6.1
* Update to RAJA v2024.02.0
* Update to Umpire 2024.02.0
* Use new way of exporting tpls
* Disable failing container builds since container images are being revamped
* Allow failure for the job using libcpp - doesn't play nicely with fmt at the moment
* Use branch of radiuss-spack-configs to fix spack builds
* Add install tests
* Add a file with release notes
* Ignoring runner issues on tioga since the jobs passed previously

* [Woptim] update spack + update to rocm 5.7.1 (#245)

* Update Spack version
* Update RADIUSS Spack Configs with February 2024 release changes

---------

Co-authored-by: Alan Dayton <[email protected]>

* Update version numbers

---------

Co-authored-by: David Beckingsale <[email protected]>
Co-authored-by: Benjamin T. Liu <[email protected]>
Co-authored-by: Kristi <[email protected]>
Co-authored-by: Kristi <[email protected]>
Co-authored-by: Arturo Vargas <[email protected]>
Co-authored-by: robinson96 <[email protected]>
Co-authored-by: Adrien Bernede <[email protected]>
Co-authored-by: Neela Kausik <[email protected]>
Co-authored-by: Ben Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants