-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.7 #47
Prepare for 0.7 #47
Conversation
mod: README.md Comment, issue JuliaWeb#43 URI field mod: REQUIRE Drop 0.5 mod: src/HttpCommon.jl AbstractString -> String. Constructors accepting AbstractString.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 30 33 +3
=====================================
+ Hits 30 33 +3
Continue to review full report at Codecov.
|
I'm not able to reproduce the test failure locally (using 0.7 build 2549, two days old) and on windows. |
… Dict{AbstractString, AbstractString} Added two-step test for isa(HttpCommon.header(), Header)
On Windows, you can create a date like this:
...whereas on OSX (downloaded binary):
|
The Windows behaviour above has changed with JuliaLang/julia#24459. Todays behaviour is:
'using Base.Dates' in 0.7 would hopefully work in 0.6 without the need for Compat. Unfortunately it does not work as expected in 0.7 yet (Windows):
|
There has been a long standing issue with windows nightly binaries, so it is quite likely they're older versions than the mac and linux binaries. |
aviks, thanks, but downloading 0.7 binaries didn't work at all two days ago. julia-latest-win64 is 0.6.1 or dresses quite like it. The output above is from a local compilation on windows / cygwin. |
modified: REQUIRE No way around including Compat for covering 0.6 and 0.7. modified: src/HttpCommon.jl using Compat.Dates
I'd suggest merging this, and fixing any issues as they come up. Mac and linux tests on travis seems to pass on 0.6 and nightly. |
Can we merge this? It would help CoverageBase... |
Dropped supporting 0.5.
There's still a depwarn in 0.7 for 'using Base.Test'.