Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.7 #47

Merged
merged 5 commits into from
Jan 20, 2018
Merged

Prepare for 0.7 #47

merged 5 commits into from
Jan 20, 2018

Conversation

hustf
Copy link
Contributor

@hustf hustf commented Nov 22, 2017

Dropped supporting 0.5.
There's still a depwarn in 0.7 for 'using Base.Test'.

mod:   .travis.yml                 Drop 0.5
mod:   README.md                   Comment, issue #43 URI field
mod:   REQUIRE                     Drop 0.5
mod:   src/HttpCommon.jl           AbstractString -> String. Constructors accepting AbstractString.

mod:   README.md                   Comment, issue JuliaWeb#43 URI field
mod:   REQUIRE                     Drop 0.5
mod:   src/HttpCommon.jl           AbstractString -> String. Constructors accepting AbstractString.
@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          30     33    +3     
=====================================
+ Hits           30     33    +3
Impacted Files Coverage Δ
src/HttpCommon.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e546dc2...f00ff8c. Read the comment docs.

@hustf
Copy link
Contributor Author

hustf commented Nov 23, 2017

I'm not able to reproduce the test failure locally (using 0.7 build 2549, two days old) and on windows.

… Dict{AbstractString, AbstractString}

                                  Added two-step test for isa(HttpCommon.header(), Header)
@hustf
Copy link
Contributor Author

hustf commented Nov 23, 2017

On Windows, you can create a date like this:

$ julia7
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.2549 (2017-11-20 18:47 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 0f906bacff* (2 days old master)
|__/                   |  x86_64-w64-mingw32

julia> Dates.format(now(Dates.UTC), Dates.RFC1123Format)
"Thu, 23 Nov 2017 18:00:07"

...whereas on OSX (downloaded binary):

This is hopefully straightened out soon, because it's currently difficult to make this package work and test on both 0.6 and 0.7, both OSX and Windows.  | | |_| | | | (_| |  |  Version 0.7.0-DEV.2590 (2017-11-23 15:32 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit dd0bf99db7 (0 days old master)
|__/                   |  x86_64-apple-darwin14.5.0

julia> Dates.format(now(Dates.UTC), Dates.RFC1123Format)
WARNING: Base.Dates is deprecated, run `using Dates` instead.
  likely near no file:0
ERROR: type Void has no field format

@hustf
Copy link
Contributor Author

hustf commented Nov 24, 2017

The Windows behaviour above has changed with JuliaLang/julia#24459. Todays behaviour is:

  | | |_| | | | (_| |  |  Version 0.7.0-DEV.2601 (2017-11-24 14:32 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 2b326d36c9* (0 days old master)
|__/                   |  x86_64-w64-mingw32

julia> Dates.format(now(Dates.UTC), Dates.RFC1123Format)
WARNING: ERROR: Base.Dates is deprecatedtype Void has no field format, run `using Dates` instead.

'using Base.Dates' in 0.7 would hopefully work in 0.6 without the need for Compat. Unfortunately it does not work as expected in 0.7 yet (Windows):

  | | |_| | | | (_| |  |  Version 0.7.0-DEV.2601 (2017-11-24 14:32 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 2b326d36c9* (0 days old master)
|__/                   |  x86_64-w64-mingw32

julia> using Base.Dates
WARNING:
Base.Dates is deprecated, run `using Dates` instead.
  likely near no file:0
julia> Dates.format(now(Dates.UTC), Dates.RFC1123Format)
WARNING: ERROR: Base.Dates is deprecated, run `using Dates` insteadtype Void has no field format.
  likely near no file:0

@aviks
Copy link
Member

aviks commented Nov 25, 2017

There has been a long standing issue with windows nightly binaries, so it is quite likely they're older versions than the mac and linux binaries.

@hustf
Copy link
Contributor Author

hustf commented Nov 25, 2017

aviks, thanks, but downloading 0.7 binaries didn't work at all two days ago. julia-latest-win64 is 0.6.1 or dresses quite like it. The output above is from a local compilation on windows / cygwin.

	modified:   REQUIRE             No way around including Compat for covering 0.6 and 0.7.
	modified:   src/HttpCommon.jl   using Compat.Dates
@aviks
Copy link
Member

aviks commented Dec 17, 2017

I'd suggest merging this, and fixing any issues as they come up. Mac and linux tests on travis seems to pass on 0.6 and nightly.

@kshyatt
Copy link

kshyatt commented Jan 20, 2018

Can we merge this? It would help CoverageBase...

@ararslan ararslan merged commit 51c55f1 into JuliaWeb:master Jan 20, 2018
@hustf hustf mentioned this pull request Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants