Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo found in the readme.md of this page #43

Open
sarvghotra opened this issue Mar 9, 2017 · 0 comments
Open

A typo found in the readme.md of this page #43

sarvghotra opened this issue Mar 9, 2017 · 0 comments

Comments

@sarvghotra
Copy link

Here it says request has five fields but only four are listed, uri is missing.
hustf added a commit to hustf/HttpCommon.jl that referenced this issue Nov 22, 2017
@hustf
mod: .travis.yml Drop 0.5
3d68769 
mod:   README.md                   Comment, issue JuliaWeb#43 URI field
mod:   REQUIRE                     Drop 0.5
mod:   src/HttpCommon.jl           AbstractString -> String. Constructors accepting AbstractString.
ararslan pushed a commit that referenced this issue Jan 20, 2018
@hustf @ararslan
Prepare for 0.7 (#47)
51c55f1 
* mod:   .travis.yml                 Drop 0.5
mod:   README.md                   Comment, issue #43 URI field
mod:   REQUIRE                     Drop 0.5
mod:   src/HttpCommon.jl           AbstractString -> String. Constructors accepting AbstractString.

* modified:   .travis.yml     Separate depwarns from URIParser <- Compat

* modified:   test/runtests.jl      Added tests for constructing requests with Dict{AbstractString, AbstractString}
                                  Added two-step test for isa(HttpCommon.header(), Header)

* modified:   src/HttpCommon.jl     Added using Base.Dates (the 0.6 way)

* 	modified:   .travis.yml         Drop the two-step compilation again.
	modified:   REQUIRE             No way around including Compat for covering 0.6 and 0.7.
	modified:   src/HttpCommon.jl   using Compat.Dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarvghotra