-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUTEst.jl] Support Windows #350
[CUTEst.jl] Support Windows #350
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
===========================================
- Coverage 89.11% 67.54% -21.57%
===========================================
Files 5 8 +3
Lines 790 1328 +538
===========================================
+ Hits 704 897 +193
- Misses 86 431 +345 ☔ View full report in Codecov by Sentry. |
Wow, it works 😳 😲 😱 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really cool @amontoison, good job!
I am assuming this wouldn't work for anyone just testing directly on windows though, so we need a bit of documentation at least to warn them.
@@ -28,12 +28,14 @@ const cutest_problems_path = joinpath(dirname(@__FILE__), "..", "deps", "files") | |||
isdir(cutest_problems_path) || mkpath(cutest_problems_path) | |||
|
|||
function __init__() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function __init__() | |
function __init__() |
Could you just add a comment around to say why we don't do anything for Windows here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because we don't have bash
on Windows. I will add a comment in a different PR.
Yes, we require the user to have a Fortran compiler |
🤞
Should be merged after #344 and #349 if it works one day...