Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUTEst.jl] Support Windows #350

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Aug 18, 2024

🤞
Should be merged after #344 and #349 if it works one day...

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 86.77686% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (f2ad6a4) to head (b1198ed).
Report is 25 commits behind head on main.

Files Patch % Lines
src/core_interface.jl 79.01% 17 Missing ⚠️
src/libcutest.jl 50.00% 12 Missing ⚠️
src/CUTEst.jl 60.00% 2 Missing ⚠️
src/julia_interface.jl 99.21% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #350       +/-   ##
===========================================
- Coverage   89.11%   67.54%   -21.57%     
===========================================
  Files           5        8        +3     
  Lines         790     1328      +538     
===========================================
+ Hits          704      897      +193     
- Misses         86      431      +345     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison
Copy link
Member Author

Wow, it works 😳 😲 😱
cc @dpo

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really cool @amontoison, good job!
I am assuming this wouldn't work for anyone just testing directly on windows though, so we need a bit of documentation at least to warn them.

@@ -28,12 +28,14 @@ const cutest_problems_path = joinpath(dirname(@__FILE__), "..", "deps", "files")
isdir(cutest_problems_path) || mkpath(cutest_problems_path)

function __init__()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function __init__()
function __init__()

Could you just add a comment around to say why we don't do anything for Windows here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because we don't have bash on Windows. I will add a comment in a different PR.

@amontoison
Copy link
Member Author

That's really cool @amontoison, good job! I am assuming this wouldn't work for anyone just testing directly on windows though, so we need a bit of documentation at least to warn them.

Yes, we require the user to have a Fortran compiler gfortran for now but I know how to install it as an artifact for users so it will be very user-friendly in the future. I will reuse the artifacts of Artifacts.toml from PackageCompiler.jl.

@amontoison amontoison merged commit 2ce49d5 into JuliaSmoothOptimizers:main Aug 19, 2024
9 of 15 checks passed
@amontoison amontoison deleted the windows-support branch August 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants