Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Julia wrappers in CUTEst.jl -- Part III #344

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Aug 17, 2024

  • use the Julia wrappers in libcutest.jl to easily update CUTEst_jll.jl in the future and support various precision.
  • Update functions in core_interface.jl to use the C version *_cint_* instead of the F77 version because the type logical can have different sizes depending on the Fortran compiler.

The following routines are concerned:

  • cutest_cint_csetup
  • cutest_cint_cnoobj
  • cutest_cint_uofg
  • cutest_cint_ueh
  • cutest_cint_ugreh
  • cutest_cint_uhprod
  • cutest_cint_ushprod
  • cutest_cint_cofg
  • cutest_cint_cofsg
  • cutest_cint_ccfg
  • cutest_cint_clfg
  • cutest_cint_cgr
  • cutest_cint_csgr
  • cutest_cint_csgrp
  • cutest_cint_csjp
  • cutest_cint_ccfsg
  • cutest_cint_ccifg
  • cutest_cint_ccifsg
  • cutest_cint_cgrdh
  • cutest_cint_csgrsh
  • cutest_cint_csgrshp
  • cutest_cint_csgreh
  • cutest_cint_chprod
  • cutest_cint_chsprod
  • cutest_cint_chcprod
  • cutest_cint_cshcprod
  • cutest_cint_chjprod
  • cutest_cint_cjprod
  • cutest_cint_csjprod
  • cutest_cint_cchprods
  • cutest_cint_cchprodsp
  • cutest_cint_cohprods

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 87.06897% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.29%. Comparing base (f2ad6a4) to head (c76ab72).
Report is 23 commits behind head on main.

Files Patch % Lines
src/core_interface.jl 78.48% 17 Missing ⚠️
src/libcutest.jl 50.00% 12 Missing ⚠️
src/julia_interface.jl 99.21% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #344       +/-   ##
===========================================
- Coverage   89.11%   67.29%   -21.82%     
===========================================
  Files           5        8        +3     
  Lines         790     1324      +534     
===========================================
+ Hits          704      891      +187     
- Misses         86      433      +347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison requested a review from tmigot August 17, 2024 23:38
@amontoison amontoison marked this pull request as ready for review August 17, 2024 23:40
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @amontoison !

@tmigot tmigot merged commit 908a1ce into JuliaSmoothOptimizers:main Aug 19, 2024
9 of 15 checks passed
@amontoison amontoison deleted the wrappers2 branch August 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants