Added increment! and decrement! functions.
#314
Conversation
|
Hi @Jay-sanjay, thanks for the PR. Unfortunately, that is not the |
|
@abelsiqueira sir do check is it the way the |
There was a problem hiding this comment.
Hi @Jay-sanjay, thanks. That is the correct usage, but you don't have to define the functions again since they are already present in the NLPModels.jl package.
src/julia_interface.jl
Outdated
| """ | ||
| increment!(nlp, s) | ||
|
|
||
| Increment counter `s` of problem `nlp`. | ||
| """ | ||
| @inline function increment!(nlp::AbstractNLPModel, s::Symbol) | ||
| increment!(nlp, Val(s)) | ||
| end | ||
|
|
||
| for fun in fieldnames(Counters) | ||
| @eval increment!(nlp::AbstractNLPModel, ::Val{$(Meta.quot(fun))}) = nlp.counters.$fun += 1 | ||
| end | ||
|
|
||
| """ | ||
| decrement!(nlp, s) | ||
|
|
||
| Decrement counter `s` of problem `nlp`. | ||
| """ | ||
|
|
||
| function decrement!(nlp::AbstractNLPModel, s::Symbol) | ||
| setproperty!(nlp.counters, s, getproperty(nlp.counters, s) - 1) | ||
| end | ||
|
|
There was a problem hiding this comment.
These shouldn't be necessary since they are already defined in NLPModels.jl. Just remove them.
| @@ -43,7 +66,7 @@ function NLPModels.objcons!( | |||
| f, | |||
| ) | |||
| end | |||
| nlp.counters.neval_obj += 1 | |||
| increment!(nlp, :neval_obj) | |||
There was a problem hiding this comment.
Yes, this is the correct usage.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Fixes #292
updated julia_interface.jl