Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use increment! and decrement! functions #292

Closed
tmigot opened this issue Aug 8, 2022 · 3 comments · Fixed by #314
Closed

Use increment! and decrement! functions #292

tmigot opened this issue Aug 8, 2022 · 3 comments · Fixed by #314
Labels
good first issue

Comments

@tmigot
Copy link
Member

tmigot commented Aug 8, 2022 •
edited by abelsiqueira
Loading

instead of doing this

CUTEst.jl/src/julia_interface.jl

Line 43 in 7ea04f4

nlp.counters.neval_obj += 1

use the increment! function like here
https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/d4c48d2fd7d599aee83b97624d3299b3fcd98c1f/src/nlp.jl#L537

The function is defined here: https://github.com/JuliaSmoothOptimizers/NLPModels.jl/blob/main/src/nlp/counters.jl#L59
@Jay-sanjay Jay-sanjay mentioned this issue Oct 1, 2023
Merged
@Jay-sanjay
Copy link
Contributor

@tmigot sir I have raised a PR for it, please do review it .

@abelsiqueira
Copy link
Member

@Jay-sanjay, I've updated the issue definition with more information

@Jay-sanjay
Copy link
Contributor

Thank you sir , I will start to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added increment! and decrement! functions. Jay-sanjay/CUTEst.jl
3 participants
@abelsiqueira @tmigot @Jay-sanjay