-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bindeps again #105
Bindeps again #105
Conversation
If you restart the OSX jobs, you should see the same issue as in #104. |
1 similar comment
ac18f7a
to
5022817
Compare
1 similar comment
error("libgfortran.so not found. Did you install it?") | ||
end | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it CUTEst.jl
's job to search for libgfortran
? It seems you're searching very standard locations. If it's in one of those, it should be on the library path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to have the easiest way possible to install CUTEst.jl
. BinDeps doesn't let me install using sudo
, so we're gonna have to ask the user to install manually with apt-get
, pacman
or whatever he uses. But where is libgfortran.so
after installation is another problem, because it varies with the distribution and even the Ubuntu version, so I was trying to just search for it, instead. I think /usr/local/lib
might sometimes not be in the library path (might be distribution specific). usr/lib
can probably be skipped though.
However, if you think this is too much, I can remove it, and this is probably the most we can do: install gsl-1.16 for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that installing gfortran in such a way that libgfortran can be found is gfortran's responsibility. I thought BinDeps let you declare pacman, apt-get, etc., dependencies. What good are they if you can't install them? I feel this is overkill and it's reasonable to ask the user to have gfortran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing gfortran in such a way that libgfortran can be found is gfortran's responsibility
I don't know who to complain about it. Possibly apt mantainers?
I thought BinDeps let you declare pacman, apt-get, etc., dependencies
It should, but it is broken. See here.
b9a37de
to
c42407c
Compare
23f9309
to
b34aa51
Compare
The only failures are on 0.6. The |
2 similar comments
6e86d17
to
e8fc94b
Compare
Rebased |
2 similar comments
Excellent, thank you! |
* Install gsl-1.16 with BinDeps * Don't need sudo anymore * Add BinDeps to REQUIRE * Add include path for gsl * Update travis to fix libgfortran.so location * Update docs to reflect changes in installation
|
||
if is_apple() | ||
if Pkg.installed("Homebrew") === nothing | ||
error("Homebrew package not installed, please run Pkg.add(\"Homebrew\")") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unnecessary and redundant with @osx Homebrew
in the REQUIRE file - all the packages you see this in have cargo-cult copy pasted it despite it being incorrect
The latest build fails because of sudo (discourse,
JuliaPackaging/BinDeps.jl#199)), thwarting my plans of one-commands-install-all.
My current strategy is building
gsl-1.16
using BinDeps, and requiring the user to installgfortran
separately.The next steps are to make sure that
libgfortran
is visible, possibly insidedeps
.