Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindeps again #105

Merged
merged 6 commits into from
Jan 22, 2017
Merged

Conversation

abelsiqueira
Copy link
Member

The latest build fails because of sudo (discourse,
JuliaPackaging/BinDeps.jl#199)), thwarting my plans of one-commands-install-all.

My current strategy is building gsl-1.16 using BinDeps, and requiring the user to install gfortran separately.

The next steps are to make sure that libgfortran is visible, possibly inside deps.

@dpo
Copy link
Member

dpo commented Dec 9, 2016

If you restart the OSX jobs, you should see the same issue as in #104.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.3% when pulling ac18f7a on abelsiqueira:bindeps-again into f1f853f on JuliaSmoothOptimizers:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.3% when pulling ac18f7a on abelsiqueira:bindeps-again into f1f853f on JuliaSmoothOptimizers:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling 5022817 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling 5022817 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

error("libgfortran.so not found. Did you install it?")
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it CUTEst.jl's job to search for libgfortran? It seems you're searching very standard locations. If it's in one of those, it should be on the library path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to have the easiest way possible to install CUTEst.jl. BinDeps doesn't let me install using sudo, so we're gonna have to ask the user to install manually with apt-get, pacman or whatever he uses. But where is libgfortran.so after installation is another problem, because it varies with the distribution and even the Ubuntu version, so I was trying to just search for it, instead. I think /usr/local/lib might sometimes not be in the library path (might be distribution specific). usr/lib can probably be skipped though.
However, if you think this is too much, I can remove it, and this is probably the most we can do: install gsl-1.16 for the user.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that installing gfortran in such a way that libgfortran can be found is gfortran's responsibility. I thought BinDeps let you declare pacman, apt-get, etc., dependencies. What good are they if you can't install them? I feel this is overkill and it's reasonable to ask the user to have gfortran.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installing gfortran in such a way that libgfortran can be found is gfortran's responsibility

I don't know who to complain about it. Possibly apt mantainers?

I thought BinDeps let you declare pacman, apt-get, etc., dependencies

It should, but it is broken. See here.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 62.289% when pulling b9a37de on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage remained the same at 62.388% when pulling c42407c on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

@abelsiqueira abelsiqueira force-pushed the bindeps-again branch 2 times, most recently from 23f9309 to b34aa51 Compare December 20, 2016 02:58
@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage remained the same at 62.388% when pulling b34aa51 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

@abelsiqueira
Copy link
Member Author

The only failures are on 0.6. The sudo ln -s is back on Travis, and the installation is udpated.

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage remained the same at 62.388% when pulling 6e86d17 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling 6e86d17 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling 6e86d17 on abelsiqueira:bindeps-again into 0b3415e on JuliaSmoothOptimizers:develop.

@abelsiqueira abelsiqueira mentioned this pull request Jan 2, 2017
9 tasks
@abelsiqueira
Copy link
Member Author

Rebased

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling e8fc94b on abelsiqueira:bindeps-again into 2230ece on JuliaSmoothOptimizers:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling e8fc94b on abelsiqueira:bindeps-again into 2230ece on JuliaSmoothOptimizers:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling e8fc94b on abelsiqueira:bindeps-again into 2230ece on JuliaSmoothOptimizers:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.388% when pulling e8fc94b on abelsiqueira:bindeps-again into 2230ece on JuliaSmoothOptimizers:develop.

@dpo
Copy link
Member

dpo commented Jan 22, 2017

Excellent, thank you!

@dpo dpo merged commit 4fda4dd into JuliaSmoothOptimizers:develop Jan 22, 2017
@abelsiqueira abelsiqueira deleted the bindeps-again branch January 22, 2017 16:05
dpo pushed a commit that referenced this pull request Jan 22, 2017
* Install gsl-1.16 with BinDeps
* Don't need sudo anymore
* Add BinDeps to REQUIRE
* Add include path for gsl
* Update travis to fix libgfortran.so location
* Update docs to reflect changes in installation

if is_apple()
if Pkg.installed("Homebrew") === nothing
error("Homebrew package not installed, please run Pkg.add(\"Homebrew\")")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unnecessary and redundant with @osx Homebrew in the REQUIRE file - all the packages you see this in have cargo-cult copy pasted it despite it being incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants