Build CUTEst inside deps/ #104
Conversation
|
I should add, this fixes #103. |
|
The OSX errors arise from installation (click to expand the |
|
Must be a recent change in Homebrew. I'll have a look asap. |
|
I am wondering if the issue comes from Travis/OSX because I can't reproduce locally. I "fixed" the Homebrew formula for CUTEst to make Travis happy and now it installs, but there's an error further down, in the tests. I can't reproduce them locally either. |
|
I restarted CUTEst develop branch and it works for 0.4 and 0.5. There is something here that is breaking OSX. Look at this line. It shows that CUTEst on OSX was installed on a tmp dir. |
| @@ -10,14 +10,15 @@ function validate_libcutest() | |||
| tmpdir = mktempdir() | |||
| cd(tmpdir) | |||
There was a problem hiding this comment.
This line is not needed, line 13 already calls it.
| end | ||
| end | ||
| println(cenv, "ENV[\"CUTEst problems\"] = \"$(pwd())/problems\"") |
There was a problem hiding this comment.
This pwd() is possibly wrong.
| run(`wget $lnxurl -O install.sh`) | ||
| run(`bash install.sh --install-deps`) | ||
| @static if is_linux() | ||
| cd(here) do |
| path = chomp(split(line, "=")[2]) | ||
| write(cenv, "ENV[\"$var\"] = \"$path\"\n") | ||
| end | ||
| println(cenv, "ENV[\"CUTEst problems\"] = \"$(pwd())/problems\"") |
There was a problem hiding this comment.
I don't think this is necessary; all problems in that folder are already in ENV["MASTSIF"].
There was a problem hiding this comment.
This is for the .so, .f and .d files, I believe, so that the workdir remains clear.
|
I made a debug commit and indeed the problem is what's mentioned above: The |
|
Yes, that seems right. Thanks @abelsiqueira! |
|
Pushed with fix. Thanks @timholy . |
|
Thanks for implementing the fix! I got busy with other things. |
The first commit downloads the files into a directory
deps/files. After checking for a "global" installation (ref #103 (comment)), it then checks for a "local" (julia-specific) install. Only if the latter is not found does it download and install the files. EDIT: this will avoid unnecessary re-installations whenever you tag a new version of CUTEst (Pkg.buildruns every time a package gets updated).The second commit may be more controversial. It adds a new environment variable,
CUTEst problemswhich points to the directorydeps/files/problems. It leverages this to build all the*.sofiles (and theAUTOMAT.dandOUTSDIF.dfiles) inside this folder, rather than the user's current folder. I've been deleting.sofiles from various folders that I run CUTEst problems in, so centralizing these files seems like a nice way to prevent clutter. On the other hand, I wonder if it's currently possible to have two different julia sessions running in two different directories, both working on CUTEst problems; if this gets centralized, that won't be possible anymore (I presume). If so, I guess one option would be to build them in a temporary folder, and have each julia session generate a different random temporary.