release-1.7: Backports for 1.7-rc2 #42255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]> (cherry picked from commit 60fd334)
(cherry picked from commit 4627729)
(cherry picked from commit 70cc57c)
Fixes JuliaCI/CoverageTools.jl#48 (cherry picked from commit 664c06e)
|
Yeah, I'll try without that part and see if the tests still pass. |
|
yes, |
KristofferC
force-pushed
the
backports-release-1.7
branch
from
d9a4b21 to
9741f5c
Compare
|
yeah, just drop that commit (unless that test starts failing on CI) |
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug. (cherry picked from commit e50603f)
(cherry picked from commit 4f3a89e)
* Test circshift with 0-dim array * circshift returns dest array for a 0-dim array * use isempty instead of checking size (cherry picked from commit 144ed87)
(cherry picked from commit 1e6c269)
(cherry picked from commit 2174ee1)
* add `@constprop` for compatibility to 1.7 This also adds a depwarn for `@aggressive_constprop`, which seemed sensible to me, given that it will be removed in 1.8.
…42347) The crash in #42264 showed up when attempting to record the new value for an SSA rename during unionsplit inlining. Such a crash would only happen when `compact.idx == 1`, which is an unusual condition, because it implies that no statement of the original function had yet been processed (which is odd, because the call being inlined must have been processed by this point). As it turns out, there is currently exactly one case where this happens. If the inliner sees an `_apply_iterate` (e.g. from splatting) of something that is not a Tuple or SimpleVector (thus requiring calls to `iterate` to expand the value during `apply`), and if inference was able to determine the total length of the resulting iteration, a special case early inliner, will expand out the splat into explicit iterate calls. E.g. a call like: %r = tuple((x::Pair)...) will be expanded out to %a = iterate(x::Pair) %b = getfield(%a, 1) %c = getfield(%a, 2) %d = iterate(x, %c) %e = getfield(%d, 1) %f = getfield(%d, 2) iterate(x, %f) %r = tuple(%b, %e) where the inserted `iterate` calls may themselves be inlined. These newly inserted calls are "pending nodes" during the actual inlining. Thus, if the original apply call was the first statement of the function, these nodes would be processed before processing the statements in the function themselves. In particular, this investigation also shows that `compact.idx`, which is the current location in the function being inlined into is the wrong value to use for SSA renaming. Rather, we need to use the SSA value of the just-inserted statement. In the absence of pending nodes, these are equivalent concepts, but not for pending nodes. Fortunately the IncrementalCompact iterator provides the old SSA value for just this reason and in fact, non-UnionSplit inlining was already correct here. Thus, to fix the issue, simply adjust union splitting to work the same way as a non-UnionSplit inline. In coming up with the test case, an additional complication is that we currently do not perform this optimization for any calls where the apply call itself was unionsplit. It is somewhat unusual (which explains why we haven't seen this much) for the apply to not be union-split, but for the subsequent `iterate` to require union-splitting. In the problem case, what happened is that for two out of the three union cases, the `iterate` calls themselves would error, causing the resulting info object to look like a non-unionsplit apply call, triggering this issue. Co-authored-by: Keno Fischer <[email protected]> (cherry picked from commit b5f3a99)
* [GMP] Patch for Apple Silicon (cherry picked from commit 764159c)
|
Buildkite is now passing on this PR. |
* fix exp(NaN16) and add tests (cherry picked from commit c8cc1b5)
* [LLVM] bump to 12.0.1-4 * Clang is now installed into usr/tools (cherry picked from commit 538541a)
(cherry picked from commit 2f00fe1)
(cherry picked from commit b239886)
Backport LLVM 12.0.1-4 bump to 1.7
(cherry picked from commit 6893f21)
(cherry picked from commit c13d5fe)
(cherry picked from commit 2bdbc6f)
(cherry picked from commit b8ed1ae)
The SparseMatrixCSC constructor checks that the passed in buffers have length matching the expected number of non-zeros, but the _outer constructor allocated buffers of the number of structural non-zeros, not actual non-zeros. Fix this by shrinking the buffers once the outer product is fully computed. (cherry picked from commit d885fc2)
(cherry picked from commit 02f7861)
(cherry picked from commit a11d804)
(cherry picked from commit f2080d5)
vchuravy
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Oct 6, 2023
…ease-1.7 release-1.7: Backports for 1.7-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asanjob, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) #42229::#42221Any32type infilterfor tuples #42263jl_setjmpon windows #42267hastypemaxonBool#42300@timecompilation time measurement, using _tryfinally macro. #41923package_linuxandtester_linuxfor more Linux architectures #41707Statusesworkflow when a pull request is opened or synchronized #42389retry-buildkiteaction #42386read()respectlock=false#42394jl_options#42416OPENBLAS_NUM_THREADSenvironment variable #42470asanjob from "experimental" to "main" #42478package_musl64andtester_musl64(Linux, musl libc, 64-bit, x86_64 architecture) #42476tester_linux.ymlfile #42514asanjob to fail #42541stale_cachefileto ignore loaded modules (for Pkg.precompile) #42545tryparse(Bool, " ")#42623cfunction#42635labeledtrigger #42642jl_field_isdefined#42611USE_BINARYBUILDER=0(and runs the test suite) on linux64 #42592_isequal,_isless,__inc, and__dec#42686printstyled#42547Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
asanjob to fail #42548RandomDevicefile from__init__#42537names()instead of the binding #42532refs/pull/1234/merge) #42403usingthread-safe #41602