-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collect on stateful generator #41919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Aug 18, 2021
The CI failure come from an an inference failure that reduces to this:
I can try to work around it, but looking at it as a human, without understanding how the compiler works, it appears to be something that type inference ought to be able to figure out? |
Okay I decided to work around it. |
vtjnash
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Aug 24, 2021
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
This was referenced Aug 25, 2021
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
KristofferC
pushed a commit
that referenced
this pull request
Aug 31, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 3, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Previously this code would drop 1 from the length of some generators. Fixes JuliaLang#35530
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Generalization of JuliaLang#41919 Fixes JuliaLang#42168
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Previously this code would drop 1 from the length of some generators. Fixes JuliaLang#35530
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Generalization of JuliaLang#41919 Fixes JuliaLang#42168
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35530.