Update use of Observables listeners to current interface #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-MWE:
"hover", "click", etc) gave the following error when updating/being run:
I narrowed the problem down to an incorrect assumption about what is
returned from
Observables.listeners
. The previous expectation was anarray of functions, the reality is a
Vector{Pair,Function}
.WebIO#master doesn't pass tests on my machine, so I can't say with certainty that this doesn't cause any problems, but this does fix the example issue above.
I removed the conditional test for a ~2yo Observables version and removed the corresponding compat entry.