Use authorization for js imports #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
======================================
Coverage 60.8% 60.8%
======================================
Files 14 14
Lines 398 398
======================================
Hits 242 242
Misses 156 156Continue to review full report at Codecov.
|
halleysfifthinc
added a commit
to halleysfifthinc/WebIO.jl
that referenced
this pull request
Oct 29, 2022
Non-MWE:
- In IJulia, with PlotlyJS, an observer on a plot event (e.g.
"hover", "click", etc) gave the following error when updating/being run:
```julia
KERNEL EXCEPTION
MethodError: objects of type Pair{Int64, Any} are not callable
Stacktrace:
[1] #invokelatest#2
@ ./essentials.jl:729 [inlined]
[2] invokelatest
@ ./essentials.jl:726 [inlined]
[3] set_nosync(ob::Observable{Dict{Any, Any}}, val::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/scope.jl:355
[4] dispatch(ctx::Scope, key::String, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/scope.jl:368
[5] dispatch_command(conn::WebIO.IJuliaConnection, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/messaging.jl:104
[6] dispatch(conn::WebIO.IJuliaConnection, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/messaging.jl:81
[7] (::WebIO.var"JuliaGizmos#97#98"{WebIO.IJuliaConnection})(msg::IJulia.Msg)
@ WebIO ~/.julia/dev/WebIO/src/providers/ijulia.jl:21
[8] comm_msg(sock::ZMQ.Socket, msg::IJulia.Msg)
@ IJulia.CommManager ~/.julia/packages/IJulia/AQu2H/src/comm_manager.jl:134
[9] #invokelatest#2
@ ./essentials.jl:729 [inlined]
[10] invokelatest
@ ./essentials.jl:726 [inlined]
[11] eventloop(socket::ZMQ.Socket)
@ IJulia ~/.julia/packages/IJulia/AQu2H/src/eventloop.jl:8
[12] (::IJulia.var"JuliaGizmos#15#18")()
@ IJulia ./task.jl:484
```
I narrowed the problem down to an incorrect assumption about what is
returned from `Observables.listeners`. The previous expectation was an
array of functions, the reality is a `Vector{Pair,Function}`.
halleysfifthinc
added a commit
to halleysfifthinc/WebIO.jl
that referenced
this pull request
Oct 31, 2022
Non-MWE:
- In IJulia, with PlotlyJS, an observer on a plot event (e.g.
"hover", "click", etc) gave the following error when updating/being run:
```julia
KERNEL EXCEPTION
MethodError: objects of type Pair{Int64, Any} are not callable
Stacktrace:
[1] #invokelatest#2
@ ./essentials.jl:729 [inlined]
[2] invokelatest
@ ./essentials.jl:726 [inlined]
[3] set_nosync(ob::Observable{Dict{Any, Any}}, val::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/scope.jl:355
[4] dispatch(ctx::Scope, key::String, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/scope.jl:368
[5] dispatch_command(conn::WebIO.IJuliaConnection, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/messaging.jl:104
[6] dispatch(conn::WebIO.IJuliaConnection, data::Dict{String, Any})
@ WebIO ~/.julia/dev/WebIO/src/messaging.jl:81
[7] (::WebIO.var"JuliaGizmos#97#98"{WebIO.IJuliaConnection})(msg::IJulia.Msg)
@ WebIO ~/.julia/dev/WebIO/src/providers/ijulia.jl:21
[8] comm_msg(sock::ZMQ.Socket, msg::IJulia.Msg)
@ IJulia.CommManager ~/.julia/packages/IJulia/AQu2H/src/comm_manager.jl:134
[9] #invokelatest#2
@ ./essentials.jl:729 [inlined]
[10] invokelatest
@ ./essentials.jl:726 [inlined]
[11] eventloop(socket::ZMQ.Socket)
@ IJulia ~/.julia/packages/IJulia/AQu2H/src/eventloop.jl:8
[12] (::IJulia.var"JuliaGizmos#15#18")()
@ IJulia ./task.jl:484
```
I narrowed the problem down to an incorrect assumption about what is
returned from `Observables.listeners`. The previous expectation was an
array of functions, the reality is a `Vector{Pair,Function}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this resolves #96 although it's tricky to test because
Pkgoperations don't work on JuliaBox (and the packages themselves aren't git repos).Unfortunately, it looks like my version of
webpackmust be slightly different, because the bundled JS has a ton of meaningless changes. If you want to minimize the size of this diff, you might want to just take my first commit (2e98ad6) which has the actual change and then regenerate the bundles yourself with whatever the right version of webpack is.