Improvements to get_image_command #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes ambiguity as to what we're trying to inspect.
This allows callers of get_image_command() to handle this case differently. Unfortunately, 'docker inspect' can return 1 in other error cases, so we have no choice but to key on the stderr text :-\
In the case where we're trying to inspect an image that has not yet been downloaded, try to pull it first. This fixes #79
This adds more complexity and confusion than it is worth. Also, we now have tests that count on the state of the local image repository, so don't let tests potentially screw each other up.
JonathonReinhart
force-pushed
the
79-inspect-fixes
branch
from
90f2628 to
f75e4b6
Compare
Current coverage is 97.58% (diff: 86.66%)@@ master #81 diff @@
==========================================
Files 9 9
Lines 433 456 +23
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 426 445 +19
- Misses 7 11 +4
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #79, and adds some other small UI improvements around 'docker inspect'.