Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scuba fails to inspect image that doesn't yet exist #79

Closed
JonathonReinhart opened this issue Sep 1, 2016 · 0 comments · Fixed by #81
Closed

Scuba fails to inspect image that doesn't yet exist #79

JonathonReinhart opened this issue Sep 1, 2016 · 0 comments · Fixed by #81
Milestone
v2.0

Comments

@JonathonReinhart
Copy link
Owner

JonathonReinhart commented Sep 1, 2016 •
edited
Loading

If you try to run an image w/o arguments, scuba needs to inspect the image to determine its original COMMAND. The problem is, if the image doesn't exist yet, it can't yet be inspected.

$ scuba
Error: No such image or container: centos:6
scuba: Failed to inspect image

This was broken in v1.7.0 (by 2a58a8c) when we changed the entrypoint to scubainit.
@JonathonReinhart JonathonReinhart added this to the v2.0 milestone Sep 15, 2016
JonathonReinhart added a commit that referenced this issue Sep 30, 2016
@JonathonReinhart
scuba: Add get_image_command_or_pull()
86e6f26 
In the case where we're trying to inspect an image that has not yet been
downloaded, try to pull it first.

This fixes #79
@JonathonReinhart JonathonReinhart mentioned this issue Sep 30, 2016
Merged
JonathonReinhart added a commit that referenced this issue Sep 30, 2016
@JonathonReinhart
scuba: Change get_image_command() to pull image if missing
dc0b04e 
In the case where we're trying to inspect an image that has not yet been
downloaded, try to pull it first.

This fixes #79
JonathonReinhart added a commit that referenced this issue Sep 30, 2016
@JonathonReinhart
Update CHANGELOG for #79
39451c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Improvements to get_image_command JonathonReinhart/scuba
1 participant
@JonathonReinhart