Support numpy >= 2.x on Python >= 3.8

[manthey]

This switches from np.prod to math.prod when math.prod exists (Python >= 3.8). With this change, the tests all pass with numpy >= 2. Note that numpy 2 doesn't exist for Python < 3.8, so this is a safe check.

Closes #100.

[manthey]

@pieper Is there anything I can do to help get this merged? Thank you.

[pieper]

I was hoping that someone with more a vested interest in this library might chime in to comment.

To me the goal sounds good, although I'd tend to think we should drop support for Python 2 at this point but I guess there's no point in potentially breaking things arbitrarily for a small fix.

Regarding the code itself, I'd suggest not repeating the check but instead centralizing it as a self._prod and putting the check in the init method.

[manthey]

To me the goal sounds good, although I'd tend to think we should drop support for Python 2 at this point but I guess there's no point in potentially breaking things arbitrarily for a small fix.

This would be dropping Python 3.6 and 3.7 (not 2.x), but that is a larger scope and I don't if there are any stakeholders of the library that still want retired Python versions.

Regarding the code itself, I'd suggest not repeating the check but instead centralizing it as a self._prod and putting the check in the init method.

Refactored in 0049c69

[pieper]

So the 3.7 test is failing, which I guess is expected? Should we somehow force older numpy for 3.7 or drop it?

https://github.com/ImagingDataCommons/dicomweb-client/actions/runs/11353082712/job/31582437962?pr=101

[manthey]

So the 3.7 test is failing, which I guess is expected? Should we somehow force older numpy for 3.7 or drop it?

https://github.com/ImagingDataCommons/dicomweb-client/actions/runs/11353082712/job/31582437962?pr=101

I should have placed the code that checks for math.prod earlier in the __init__ method. See 1076427.

[pieper]

Hmm, looks like there's still some issue going on.

https://github.com/ImagingDataCommons/dicomweb-client/actions/runs/11366769069/job/31618096659?pr=101

[pieper]

Okay, looks like that got it 👍

[pieper]

Thanks for working through this.

[manthey]

Thank you!

[manthey]

@pieper And, lastly, can we do a patch version release? It looks like the process is to modify the version in https://github.com/ImagingDataCommons/dicomweb-client/blob/master/src/dicomweb_client/__init__.py and then create a github release. I can make a PR for the version number, if that is useful.

[pieper]

Yes, if you don't mind making a PR that would be great.

I don't think I've ever making a release here or getting it onto pypi. But I see that @CPBridge did the last one so maybe he can help here.

[CPBridge]

Yes I can do this. Sorry I have been a bit negligent on this repo. I see there are another couple of PRs that could be quick merges and then I'll push out a release. Thanks @manthey for your help on this!