Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy 2 compatibility #100

Closed
manthey opened this issue Oct 9, 2024 · 2 comments · Fixed by #101
Closed

numpy 2 compatibility #100

manthey opened this issue Oct 9, 2024 · 2 comments · Fixed by #101

Comments

@manthey
Copy link
Contributor

manthey commented Oct 9, 2024

It would be great were compatible with numpy >= 2. It looks like the only change would be to convert np.prod to math.prod, though math.prod is a Python >= 3.8 feature, so if 3.7 compatibility is still desired, it could be changed to (math.prod if hasattr(math, 'prod') else np.prod). There are two instances in file.py.
@pieper
Copy link
Member

pieper commented Oct 9, 2024

That sounds reasonable. Can you make a PR?

@manthey manthey mentioned this issue Oct 9, 2024
Merged
@manthey
Copy link
Contributor Author

manthey commented Oct 9, 2024

That sounds reasonable. Can you make a PR?

Thanks @pieper . See #101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support numpy >= 2.x on Python >= 3.8 manthey/dicomweb-client
2 participants
@pieper @manthey