Save/load refinement statuses in the state file #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously not being saved/loaded because we are saving the instrument config differently from how we do so with QSettings. In state files, we are using hexrd's HEDMInstrument to write out the instrument config, but this does not include refinement statuses. This PR adds a property to HexrdConfig() to create/set a dict of refinement statuses, and this dict is used to save/load the refinement statuses from the state file. Signed-off-by: Patrick Avery <[email protected]>
cjh1
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously not being saved/loaded because we are saving the
instrument config differently from how we do so with QSettings. In state
files, we are using hexrd's HEDMInstrument to write out the instrument
config, but this does not include refinement statuses.
This PR adds a property to HexrdConfig() to create/set a dict of
refinement statuses, and this dict is used to save/load the
refinement statuses from the state file.
Fixes: #1217