Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinement flags are not persistent in state save #1217

Closed
joelvbernier opened this issue May 13, 2022 · 1 comment · Fixed by #1220
Closed

Refinement flags are not persistent in state save #1217

joelvbernier opened this issue May 13, 2022 · 1 comment · Fixed by #1220
Assignees
Labels
bug Something isn't working

Comments

@joelvbernier
Copy link
Member

Upon reloading a state, any parameter refinement flags are all set to False, regardless of their value during state save.

GUI is current master.

hexrdgui                  0.8.16.dev66+g18f5ba4           dev_0    <develop>
@joelvbernier joelvbernier added the bug Something isn't working label May 13, 2022
@psavery
Copy link
Collaborator

psavery commented May 16, 2022

Looks like this is related to the fact that we are writing/loading the instrument config via HDF5 instead of through QSettings (see it being skipped here.

I think we can add an extra step in the save/load methods to include the refinement flags as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants