-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2162 & 2177 app header - privacy portal components + app header to trigger fly out menu #2174
Feature/2162 & 2177 app header - privacy portal components + app header to trigger fly out menu #2174
Conversation
3eb6955
to
ff70f82
Compare
https://jam.dev/c/e1428fa0-38ed-463c-b228-92416f4ecb66 I noticed something for the button font size is different with this PR, please see above jaber |
6fe10cd
to
1e99295
Compare
1e99295
to
5a61aeb
Compare
5a61aeb
to
86d7512
Compare
🎉 This PR is included in version 1.17.0-alpha.117 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Before (the change)
If we want to have the look for those below 5 components:
Like this figma design: https://www.figma.com/design/NRFUYjCwVoI9qMbFEG6s7J/Component-tokens?node-id=0-1&node-type=canvas&m=dev
It is impossible to override CSS right now, and if we override
--goa-text-default-color
for example, we will affect other components.This pull request is to add more specific design token variable names for those above 5 components, at the same time assigning values for those adding tokens, so it won't affect our components, but at the same time, allow other teams (specifically Privacy Portal Team) to override variable design token CSS (For example: https://github.com/vanessatran-ddi/latest-react-demo/blob/privacy-portal-components/src/override.css)
After (the change)
They can change the CSS variable token values on their app, example: https://vanessatran-ddi.github.io/latest-react-demo/
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
The below is how we can test: @lizhuomeng71 :
Step 1: Build the project:
npm run build:all
Step 2: Check The 6 above components to see if their looks are different with existing components. We don't want to have anything different.
(You can check with
ui-component-docs
bynpm link
)Accordion:
New attribute:
Button: (remain same)
Callout: (style remains the same but has a new attribute
iconTheme
)Container (remains the same)
Side Menu Group (remains the same with a new attribute
icon
)(notice: for padding issue it has a PR GovAlta/design-tokens#54 to fix)
AppHeader (styles remain the same)
If
onMenuClick
function is passed, then when it is on Tablet/Mobile, clicking the burger menu won't show up the AppHeaderMenu, but trigger the functionhandleMenuClick