Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2162 & 2177 app header - privacy portal components + app header to trigger fly out menu #2174

Merged

Conversation

vanessatran-ddi
Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi commented Oct 3, 2024

Before (the change)

If we want to have the look for those below 5 components:

It is impossible to override CSS right now, and if we override --goa-text-default-color for example, we will affect other components.
This pull request is to add more specific design token variable names for those above 5 components, at the same time assigning values for those adding tokens, so it won't affect our components, but at the same time, allow other teams (specifically Privacy Portal Team) to override variable design token CSS (For example: https://github.com/vanessatran-ddi/latest-react-demo/blob/privacy-portal-components/src/override.css)

After (the change)

They can change the CSS variable token values on their app, example: https://vanessatran-ddi.github.io/latest-react-demo/

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

The below is how we can test: @lizhuomeng71 :

Step 1: Build the project: npm run build:all

Step 2: Check The 6 above components to see if their looks are different with existing components. We don't want to have anything different.
(You can check with ui-component-docs by npm link)

Accordion:
image

New attribute:

  • iconPosition
    image

Button: (remain same)
image

Callout: (style remains the same but has a new attribute iconTheme)
image

Container (remains the same)
image

Side Menu Group (remains the same with a new attribute icon)
image

(notice: for padding issue it has a PR GovAlta/design-tokens#54 to fix)

AppHeader (styles remain the same)
image

If onMenuClick function is passed, then when it is on Tablet/Mobile, clicking the burger menu won't show up the AppHeaderMenu, but trigger the function handleMenuClick

@vanessatran-ddi vanessatran-ddi marked this pull request as draft October 3, 2024 16:50
@ArakTaiRoth ArakTaiRoth linked an issue Oct 3, 2024 that may be closed by this pull request
9 tasks
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2162-add-design-tokens branch from 3eb6955 to ff70f82 Compare October 3, 2024 19:44
@vanessatran-ddi vanessatran-ddi self-assigned this Oct 3, 2024
@vanessatran-ddi vanessatran-ddi changed the title Feature/2162 add design tokens Feature/2162 add design tokens (still pending, I will add everything into 1 PR, except form-stepper) Oct 9, 2024
@lizhuomeng71
Copy link
Collaborator

https://jam.dev/c/e1428fa0-38ed-463c-b228-92416f4ecb66

I noticed something for the button font size is different with this PR, please see above jaber

@vanessatran-ddi vanessatran-ddi force-pushed the feature/2162-add-design-tokens branch 3 times, most recently from 6fe10cd to 1e99295 Compare October 22, 2024 22:28
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review October 22, 2024 22:54
@vanessatran-ddi vanessatran-ddi linked an issue Oct 22, 2024 that may be closed by this pull request
1 task
@vanessatran-ddi vanessatran-ddi changed the title Feature/2162 add design tokens (still pending, I will add everything into 1 PR, except form-stepper) Feature/2162 & 2177 app header - privacy portal components + app header to trigger fly out menu Oct 23, 2024
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2162-add-design-tokens branch from 1e99295 to 5a61aeb Compare October 23, 2024 18:45
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2162-add-design-tokens branch from 5a61aeb to 86d7512 Compare October 23, 2024 19:19
@ArakTaiRoth ArakTaiRoth merged commit d304be1 into GovAlta:alpha Oct 23, 2024
1 check passed
@tzuge
Copy link
Collaborator

tzuge commented Oct 23, 2024

🎉 This PR is included in version 1.17.0-alpha.117 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Oct 23, 2024
@tzuge
Copy link
Collaborator

tzuge commented Oct 23, 2024

🎉 This PR is included in version 5.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Oct 30, 2024

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Oct 30, 2024

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Oct 30, 2024
@tzuge
Copy link
Collaborator

tzuge commented Dec 9, 2024

🎉 This PR is included in version 3.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
5 participants