Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate viability of component level tokens #2162

Closed
9 tasks done
Spark450 opened this issue Sep 25, 2024 · 7 comments · Fixed by #2174, GovAlta/design-tokens#48, GovAlta/design-tokens#54, GovAlta/ui-components-docs#255 or #2233
Closed
9 tasks done

Investigate viability of component level tokens #2162

Spark450 opened this issue Sep 25, 2024 · 7 comments · Fixed by #2174, GovAlta/design-tokens#48, GovAlta/design-tokens#54, GovAlta/ui-components-docs#255 or #2233
Assignees
@twjeffery @vanessatran-ddi
Labels
released on @alpha Released into alpha. released Released into production. Spike Label to use for Spikes

Comments

@Spark450
Copy link
Collaborator

Spark450 commented Sep 25, 2024 •
edited by vanessatran-ddi
Loading

Acceptance Criteria:

  • Choose from among the following components to test component-level tokens:

Demo link: DemoApp
Source code: CSS file
React files

  • - Callout

  • - Table

  • - Accordion

  • - Container

  • - Button token

  • - Side Menu

  • Once component is chosen, create the necessary component level tokens to match the figma design parameters

  • Review component with updated token values with @twjeffery to verify fidelity to Figma design

Plan to do the below:

Markup io feedback link
@Spark450 Spark450 added the Spike Label to use for Spikes label Sep 25, 2024
@Spark450 Spark450 moved this to 🏗 In progress in Design System Backlog Sep 25, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): add iconposition & replace design tokens for acco…
fb8aa92 
…rdion
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for button
3712bee
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): add iconsize & replace design tokens for callout
4d6854d
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for container
5924af6
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for goa-table
3eb6955
@vanessatran-ddi vanessatran-ddi moved this from 🏗 In progress to Testing in Design System Backlog Oct 3, 2024
This was linked to pull requests Oct 3, 2024
Feature/2162 & 2177 app header - privacy portal components + app header to trigger fly out menu #2174
Merged
feat(#2162): add design token variables for button,callout,container,… GovAlta/design-tokens#48
Merged
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): add iconsize & replace design tokens for callout
1ca3c3b
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for container
c3a8ec8
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 3, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for goa-table
ff70f82
@github-project-automation github-project-automation bot moved this from Testing to Alpha in Design System Backlog Oct 9, 2024
@Spark450 Spark450 moved this from 🏗 In progress to Alpha in Design System Backlog Oct 11, 2024
@ArakTaiRoth
Copy link
Collaborator

Re-opening as there's one more PR attached to this

@ArakTaiRoth ArakTaiRoth reopened this Oct 15, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add icon position & replace design tokens for acc…
c7f32a8 
…ordion
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for button
1fe5cf1
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add icontheme & replace design tokens for callout
28b1de2
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for container
d4a5cd8
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add icon & replace design tokens for sidemenu group
23ec0f4
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add design tokens for table
eb71b6a
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add icon position & replace design tokens for acc…
b8d25b8 
…ordion
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): replace design tokens for button
5bb6bfd
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 22, 2024
@vanessatran-ddi
feat(GovAlta#2162): add icontheme & replace design tokens for callout
68d87b6
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): add icon position & replace design tokens for accordion
908af81
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): replace design tokens for button
8722520
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): add icontheme & replace design tokens for callout
8ccc88c
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): replace design tokens for container
12dda28
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): add icon & replace design tokens for sidemenu group
b7220ca
ArakTaiRoth pushed a commit that referenced this issue Oct 23, 2024
@vanessatran-ddi @ArakTaiRoth
feat(#2162): add design tokens for table
a4f3a32
@ArakTaiRoth ArakTaiRoth linked a pull request Oct 28, 2024 that will close this issue
Feat/2162 & 2177 document GovAlta/ui-components-docs#255
Merged
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 29, 2024
@vanessatran-ddi
fix(GovAlta#2162): accordion padding for right and left icon position
57dcdc5
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Oct 29, 2024
@vanessatran-ddi
fix(GovAlta#2162): accordion padding for right and left icon position
41f26cc
@ArakTaiRoth ArakTaiRoth linked a pull request Oct 29, 2024 that will close this issue
fix(#2162): accordion padding for right and left icon position #2233
Merged
3 tasks
ArakTaiRoth pushed a commit that referenced this issue Oct 29, 2024
@vanessatran-ddi @ArakTaiRoth
fix(#2162): accordion padding for right and left icon position
f299bb9
@tzuge
Copy link
Collaborator

tzuge commented Oct 29, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.119 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Oct 29, 2024
@ArakTaiRoth ArakTaiRoth mentioned this issue Oct 30, 2024
Merged
@tzuge
Copy link
Collaborator

tzuge commented Oct 30, 2024

🎉 This issue has been resolved in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Oct 30, 2024

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Oct 30, 2024
vanessatran-ddi added a commit that referenced this issue Oct 31, 2024
@vanessatran-ddi
fix(#2162): rebase with alpha.
69dcb4e
vanessatran-ddi added a commit that referenced this issue Nov 1, 2024
@vanessatran-ddi
fix(#2162): rebase with alpha 1.17.0-alpha.119
b55025c
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Nov 5, 2024
@vanessatran-ddi
fix(GovAlta#2162): accordion - add rotate for right arrow position & …
6bd9e0a 
…dispatch onChange event
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Nov 5, 2024
@vanessatran-ddi
fix(GovAlta#2162): accordion - add rotate for right arrow position & …
1e5e559 
…dispatch onChange event
ArakTaiRoth pushed a commit that referenced this issue Nov 6, 2024
@vanessatran-ddi @ArakTaiRoth
fix(#2162): accordion - add rotate for right arrow position & dispatc…
798d590 
…h onChange event
@tzuge
Copy link
Collaborator

tzuge commented Nov 6, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.120 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 6, 2024

🎉 This issue has been resolved in version 5.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

vanessatran-ddi added a commit that referenced this issue Nov 7, 2024
@vanessatran-ddi
fix(#2162): rebase with alpha 1.17.0-alpha.119
ff2fd5a
vanessatran-ddi added a commit that referenced this issue Nov 18, 2024
@vanessatran-ddi
fix(#2162): rebase with alpha 1.17.0-alpha.119
edeee57
vanessatran-ddi added a commit that referenced this issue Nov 20, 2024
@vanessatran-ddi
fix(#2162): rebase with alpha 1.17.0-alpha.119
766feaf
vanessatran-ddi added a commit that referenced this issue Nov 29, 2024
@vanessatran-ddi @minhthytran
fix(#2162): rebase with alpha 1.17.0-alpha.119
dff42d2
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Nov 29, 2024
@vanessatran-ddi @minhthytran
fix(GovAlta#2162): rebase with alpha 1.17.0-alpha.119
970382d
@tzuge
Copy link
Collaborator

tzuge commented Dec 9, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twjeffery twjeffery

@vanessatran-ddi vanessatran-ddi

Labels
released on @alpha Released into alpha. released Released into production. Spike Label to use for Spikes
Projects
Design System Backlog
Archived in project
Milestone
No milestone
5 participants
@ArakTaiRoth @tzuge @Spark450 @twjeffery @vanessatran-ddi