Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken link #34

Open
mglisse opened this issue Nov 17, 2020 · 1 comment
Open

broken link #34

mglisse opened this issue Nov 17, 2020 · 1 comment

Comments

@mglisse
Copy link
Member

mglisse commented Nov 17, 2020

https://github.com/GUDHI/TDA-tutorial/blob/master/Tuto-GUDHI-simplicial-complexes-from-data-points.ipynb contains a link to https://render.githubusercontent.com/view/Tuto-GUDHI-simplicial-complexes-from-distance-matrix.ipynb which doesn't work. What is the preferred way of linking to another tutorial?
Hind-M added a commit to Hind-M/TDA-tutorial that referenced this issue Jul 6, 2021
@Hind-M
Fix issue GUDHI#34
5951ed0 
Replace links to tutorials inside notebooks with their urls in git repo
@Hind-M
Copy link
Contributor

Hind-M commented Jul 6, 2021

GitHub renders the linked notebooks using 'render.githubusercontent.com' domain and integrates the output as a 'nested frame'. But since the included notebook was not rendered separately and represents an entire url, it does not work.
I replaced all the included notebooks relative paths with the entire corresponding url in the git repo (cf. PR #49).
I didn't do that for the BottleneckBootstrap notebook since it is intended to be removed in PR #48.

bertrandmichel added a commit that referenced this issue Jul 8, 2021
@bertrandmichel
Merge pull request #49 from Hind-M/link_tutorials
f098a34 
Fix issue #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mglisse @Hind-M