Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent constant Vocal Resyncs on Inst-only songs #3861

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

3856

Briefly describe the issue(s) fixed.

For some reason when building the voice group in Song, whether or not the vocal files existed wasn't checked, which this PR aims to fix.

Include any relevant screenshots or videos.

Before:
https://github.com/user-attachments/assets/4152f062-c0ad-4855-960a-7971fc05c4b6

After:
https://github.com/user-attachments/assets/810f87e9-78f0-42de-a43d-a94ebd19d5a4
(please ignore there being wrong icons in the footage that's just a side effect of a thing im working on)

@github-actions github-actions bot added haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant