Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove time-based upgrade #889

Merged
merged 8 commits into from
Feb 10, 2023

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Feb 9, 2023

Description

Time based upgrade feature is removed from cosmos-sdk pr #8849 of cosmos-sdk. It reflects the work that was missing in the previous bump up process.
I'm not modified upgrade.proto in the pr, because the time variable in upgrade.proto is reverted on cosmos-sdk pr #9534.

closes: #787

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added the A: improvement Changes in existing functionality label Feb 9, 2023
@dudong2 dudong2 self-assigned this Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #889 (6e65f5f) into main (b886473) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
- Coverage   62.31%   62.31%   -0.01%     
==========================================
  Files         652      652              
  Lines       79493    79480      -13     
==========================================
- Hits        49534    49524      -10     
+ Misses      27279    27277       -2     
+ Partials     2680     2679       -1     
Impacted Files Coverage Δ
x/upgrade/types/plan.go 95.83% <100.00%> (+6.64%) ⬆️

@dudong2 dudong2 marked this pull request as ready for review February 9, 2023 10:15
@dudong2 dudong2 requested a review from tkxkd0159 February 9, 2023 16:49
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This binary(x/upgrade/types/__debug_bin) is attached by accident. Is's it?

x/upgrade/types/proposal_test.go Outdated Show resolved Hide resolved
@jaeseung-bae jaeseung-bae self-requested a review February 10, 2023 04:14
@dudong2 dudong2 merged commit 4863dfa into Finschia:main Feb 10, 2023
@dudong2 dudong2 deleted the dudong2/feat/remove-time-based-upgrade branch February 10, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove time-based upgrade
4 participants