test: restore height based plan test

Finschia · Feb 10, 2023 · 6e65f5f · 6e65f5f
1 parent ade37bf
commit 6e65f5f
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/x/upgrade/types/plan_test.go b/x/upgrade/types/plan_test.go
@@ -58,6 +58,18 @@ func TestPlanValid(t *testing.T) {
 		p     types.Plan
 		valid bool
 	}{
+		"proper by height": {
+			p: types.Plan{
+				Name:   "all-good",
+				Height: 123450000,
+			},
+			valid: true,
+		},
+		"no name": {
+			p: types.Plan{
+				Height: 123450000,
+			},
+		},
 		"IBC upgrade": {
 			p: types.Plan{
 				Height:              123450000,
@@ -70,6 +82,12 @@ func TestPlanValid(t *testing.T) {
 				Info: "important",
 			},
 		},
+		"negative height": {
+			p: types.Plan{
+				Name:   "minus",
+				Height: -12345,
+			},
+		},
 	}
 
 	for name, tc := range cases {