Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional testcases for fswap (backport #1415) #1421

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 13, 2024

Description

  • add more tests for fswap

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1415 done by [Mergify](https://mergify.com).

* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code

(cherry picked from commit 10726cf)

# Conflicts:
#	CHANGELOG.md
#	x/fswap/keeper/genesis_test.go
#	x/fswap/keeper/grpc_query_test.go
#	x/fswap/keeper/keeper_test.go
#	x/fswap/keeper/msg_server_test.go
#	x/fswap/types/genesis_test.go
#	x/fswap/types/msgs_test.go
Copy link
Contributor Author

mergify bot commented Jun 13, 2024

Cherry-pick of 10726cf has failed:

On branch mergify/bp/release/v0.48.x/pr-1415
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 10726cfaf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   x/fswap/types/config_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	deleted by us:   x/fswap/keeper/genesis_test.go
	deleted by us:   x/fswap/keeper/grpc_query_test.go
	deleted by us:   x/fswap/keeper/keeper_test.go
	deleted by us:   x/fswap/keeper/msg_server_test.go
	deleted by us:   x/fswap/types/genesis_test.go
	deleted by us:   x/fswap/types/msgs_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code
@jaeseung-bae jaeseung-bae self-assigned this Jun 14, 2024
@jaeseung-bae
Copy link
Contributor

Wrong backport

@mergify mergify bot deleted the mergify/bp/release/v0.48.x/pr-1415 branch June 14, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant