-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add additional testcases for fswap #1415
Merged
jaeseung-bae
merged 11 commits into
Finschia:main
from
jaeseung-bae:test/add-unittest-fswap
Jun 13, 2024
Merged
chore: add additional testcases for fswap #1415
jaeseung-bae
merged 11 commits into
Finschia:main
from
jaeseung-bae:test/add-unittest-fswap
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
+ Coverage 68.66% 68.83% +0.16%
==========================================
Files 767 767
Lines 63512 63512
==========================================
+ Hits 43611 43717 +106
+ Misses 17234 17135 -99
+ Partials 2667 2660 -7 |
zemyblue
reviewed
Jun 12, 2024
170210
reviewed
Jun 12, 2024
zemyblue
approved these changes
Jun 13, 2024
170210
approved these changes
Jun 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code (cherry picked from commit 10726cf) # Conflicts: # CHANGELOG.md
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code (cherry picked from commit 10726cf) # Conflicts: # CHANGELOG.md # x/fswap/keeper/genesis_test.go # x/fswap/keeper/grpc_query_test.go # x/fswap/keeper/keeper_test.go # x/fswap/keeper/msg_server_test.go # x/fswap/types/genesis_test.go # x/fswap/types/msgs_test.go
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
Jun 14, 2024
* chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code
jaeseung-bae
added a commit
that referenced
this pull request
Jun 14, 2024
* chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code
zemyblue
pushed a commit
that referenced
this pull request
Jun 14, 2024
* chore: add additional testcases for fswap (#1415) * chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code (cherry picked from commit 10726cf) # Conflicts: # CHANGELOG.md * chore: add additional testcases for fswap (#1415) * chore: add more test for grpc_query * chore: add more test for config and msg validation * chore: add more test for genesis-related things * chore: add TestMsgSetSwap for msg server * chore: add more test for keeper * chore: fix for lint * chore: update changelog * chore: rename kai to kei * chore: introduce stubGenesisState func for DRY * chore: remove unnecessary code * chore: remove unnecessary code --------- Co-authored-by: jaeseung-bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml