Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional testcases for fswap #1415

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Jun 11, 2024

Description

  • add more tests for fswap

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae marked this pull request as ready for review June 11, 2024 11:53
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (6054848) to head (28b44ed).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
+ Coverage   68.66%   68.83%   +0.16%     
==========================================
  Files         767      767              
  Lines       63512    63512              
==========================================
+ Hits        43611    43717     +106     
+ Misses      17234    17135      -99     
+ Partials     2667     2660       -7     

see 8 files with indirect coverage changes

@jaeseung-bae jaeseung-bae requested a review from 170210 June 11, 2024 11:56
x/fswap/keeper/genesis_test.go Outdated Show resolved Hide resolved
x/fswap/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/fswap/types/msgs_test.go Outdated Show resolved Hide resolved
@jaeseung-bae jaeseung-bae requested review from zemyblue and 170210 June 12, 2024 10:21
@jaeseung-bae jaeseung-bae merged commit 10726cf into Finschia:main Jun 13, 2024
38 checks passed
@jaeseung-bae jaeseung-bae deleted the test/add-unittest-fswap branch June 13, 2024 11:38
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code

(cherry picked from commit 10726cf)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code

(cherry picked from commit 10726cf)

# Conflicts:
#	CHANGELOG.md
#	x/fswap/keeper/genesis_test.go
#	x/fswap/keeper/grpc_query_test.go
#	x/fswap/keeper/keeper_test.go
#	x/fswap/keeper/msg_server_test.go
#	x/fswap/types/genesis_test.go
#	x/fswap/types/msgs_test.go
jaeseung-bae added a commit that referenced this pull request Jun 14, 2024
* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code
jaeseung-bae added a commit that referenced this pull request Jun 14, 2024
* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code
zemyblue pushed a commit that referenced this pull request Jun 14, 2024
* chore: add additional testcases for fswap (#1415)

* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code

(cherry picked from commit 10726cf)

# Conflicts:
#	CHANGELOG.md

* chore: add additional testcases for fswap (#1415)

* chore: add more test for grpc_query

* chore: add more test for config and msg validation

* chore: add more test for genesis-related things

* chore: add TestMsgSetSwap for msg server

* chore: add more test for keeper

* chore: fix for lint

* chore: update changelog

* chore: rename kai to kei

* chore: introduce stubGenesisState func for DRY

* chore: remove unnecessary code

* chore: remove unnecessary code

---------

Co-authored-by: jaeseung-bae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants