-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate all dbaas_core failures #424
Comments
Nope. Why do we need globstar? |
To not have to manually provide all files in all directories that end with |
But we don't need to provide all files, only directories, and there are not so many of them |
And all the directories inside those directories. But I believe there are not too many. I will be adding them all in any event. |
Closes #424. Co-authored-by: Alexey Palazhchenko <[email protected]>
I think what we should do to close that issue:
The second point might be the same as or related to #294. |
Perhaps we could use a |
This will take considerable time as each failure will need an issue and a PR with a repro. There are currently only 351 failures but this is due https://pkg.go.dev/path/filepath#Glob not supporting globstar, i.e. match all files and zero or more directories and subdirectories.
As a side note globstar can be enabled in Bash 4 by doing
shopt -s globstar
but I am not sure if his will allow Go to utilize the shell option.The dbaas_core suite has ~1k files in total, I think.
The text was updated successfully, but these errors were encountered: