Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate all dbaas_core failures #424

Closed
b1ron opened this issue May 8, 2023 · 6 comments · Fixed by #473, #476 or #562
Closed

Investigate all dbaas_core failures #424

b1ron opened this issue May 8, 2023 · 6 comments · Fixed by #473, #476 or #562
Assignees
Labels
code/chore Dance tool code maintenance improvements

Comments

@b1ron
Copy link
Contributor

b1ron commented May 8, 2023

This will take considerable time as each failure will need an issue and a PR with a repro. There are currently only 351 failures but this is due https://pkg.go.dev/path/filepath#Glob not supporting globstar, i.e. match all files and zero or more directories and subdirectories.

As a side note globstar can be enabled in Bash 4 by doing shopt -s globstar but I am not sure if his will allow Go to utilize the shell option.

The dbaas_core suite has ~1k files in total, I think.

@b1ron b1ron added the code/chore Dance tool code maintenance improvements label May 8, 2023
@b1ron b1ron self-assigned this May 8, 2023
@AlekSi
Copy link
Member

AlekSi commented May 8, 2023

but I am not sure if his will allow Go to utilize the shell option.

Nope.

Why do we need globstar?

@b1ron
Copy link
Contributor Author

b1ron commented May 8, 2023

Why do we need globstar?

To not have to manually provide all files in all directories that end with .js. I suppose we can do this manually.

@AlekSi
Copy link
Member

AlekSi commented May 29, 2023

But we don't need to provide all files, only directories, and there are not so many of them

@b1ron
Copy link
Contributor Author

b1ron commented Jun 6, 2023

But we don't need to provide all files, only directories, and there are not so many of them

And all the directories inside those directories. But I believe there are not too many. I will be adding them all in any event.

@b1ron b1ron closed this as completed in #473 Jun 7, 2023
b1ron added a commit that referenced this issue Jun 7, 2023
@b1ron b1ron reopened this Jun 7, 2023
AlekSi added a commit that referenced this issue Aug 17, 2023
@AlekSi AlekSi reopened this Aug 17, 2023
@AlekSi
Copy link
Member

AlekSi commented Aug 17, 2023

I think what we should do to close that issue:

  • Split dbaas_core.yml into multiple configurations to make them run in parallel.
  • Investigate if we could run multiple files per docker compose run invocation.

The second point might be the same as or related to #294.

@AlekSi AlekSi moved this from In progress to Open in Current Engineering Aug 18, 2023
@b1ron b1ron moved this from Open to In progress in Current Engineering Aug 21, 2023
@b1ron
Copy link
Contributor Author

b1ron commented Aug 25, 2023

Investigate if we could run multiple files per docker compose run invocation.

Perhaps we could use a .mongoshrc file with predefined TestData for each test before docker compose run is executed. I will need to see if that could work.

AlekSi pushed a commit that referenced this issue Aug 25, 2023
@AlekSi AlekSi moved this from In progress to Done in Current Engineering Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Dance tool code maintenance improvements
Projects
Archived in project
2 participants