Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dance with auto GOMAXPROCS build #531

Closed
b1ron opened this issue Jul 28, 2023 · 2 comments
Closed

Test dance with auto GOMAXPROCS build #531

b1ron opened this issue Jul 28, 2023 · 2 comments
Assignees
Labels
code/enhancement Some dance tool feature could work better

Comments

@b1ron
Copy link
Contributor

b1ron commented Jul 28, 2023

On CI #424 fails with unexpected results for MongoDB. The results differ when run locally. This build FerretDB/FerretDB/pull/3105 has auto GOMAXPROCS set and we should test dance with this build to see if it provides consistent results between CI and a local environment.

Docker run options to set during testing.

@b1ron b1ron self-assigned this Jul 28, 2023
@b1ron b1ron added the code/enhancement Some dance tool feature could work better label Jul 28, 2023
@b1ron b1ron moved this to Open in Current Engineering Jul 28, 2023
@b1ron
Copy link
Contributor Author

b1ron commented Aug 9, 2023

Fixed by setting certain ulimits for the service which coincide with recommended values and setting limits for cpus and memory to match the container running on CI.

The below limits will affect processes spawned by dockerd. Having the container running on CI be as close of possible to a local environment ultimately resolved the issue but I am unsure as to why.

byron@byron-ThinkCentre-M910q:~$ systemctl show docker | grep LimitNOFILE
LimitNOFILE=infinity
LimitNOFILESoft=infinity

@b1ron b1ron closed this as completed Aug 9, 2023
@b1ron b1ron moved this from Open to Done in Current Engineering Aug 9, 2023
@AlekSi AlekSi reopened this Aug 14, 2023
@github-project-automation github-project-automation bot moved this from Done to In progress in Current Engineering Aug 14, 2023
@AlekSi
Copy link
Member

AlekSi commented Aug 14, 2023

This issue was about checking if autotuning actually improves performance

@AlekSi AlekSi moved this from In progress to Open in Current Engineering Aug 18, 2023
@AlekSi AlekSi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some dance tool feature could work better
Projects
None yet
Development

No branches or pull requests

2 participants