Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/gym_robotics #269

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

m-stoll
Copy link
Contributor

@m-stoll m-stoll commented Feb 21, 2022

Use GoalEnv from gym_robotics (see openai/gym#2516)

@m-stoll
Copy link
Contributor Author

m-stoll commented Feb 21, 2022

Hmm, not as easy as we thought...
Maybe you'll figure out a solution easily.
Also this doesn't look right:
https://github.com/Farama-Foundation/gym-robotics/blob/main/setup.py#L25

@eleurent
Copy link
Collaborator

Hi,
Thank you for the suggestion!
I don't have permission to push on you PR branch, so I'll just merge this and try to fix it afterwards. I can see 3 ways to deal with this:

  • install gym_robotics from their master, rather than pypi
  • require gym version 0.21 (prior to the change), like it is done in StableBaselines3
  • don't subclass GoalEnv anymore, but just implement the compute_rewards method.

@eleurent eleurent merged commit 06da014 into Farama-Foundation:master Feb 23, 2022
@eleurent
Copy link
Collaborator

Solution 1 worked :)

eleurent added a commit that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants