Dplane sorry #12315
Merged
Dplane sorry #12315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donaldsharp
commented
Nov 14, 2022
donaldsharp
commented
- Fix a enum issue
- Fix the reported bug in Zebra sometimes does not connect to FPM #12314
Use the enum and let the compiler help us figure out what cases are being missed. Signed-off-by: Donald Sharp <[email protected]>
If you have this order in your configuration file: no fpm use-next-hop-groups fpm address 127.0.0.1 the dplane code was using the same event thread t_event and the second add event in the code was going, you already have an event scheduled and as such the second event does not overwrite it. Leaving no code to actually start the whole processing. There are probably other cli iterations that will cause this fun as well, but I'm not going to spend the time sussing them out at the moment. Fixes: FRRouting#12314 Signed-off-by: Donald Sharp <[email protected]>
|
@Mergifyio backport stable/8.4 |
✅ Backports have been created
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8348/ This is a comment from an automated CI system. |
ton31337
added a commit
that referenced
this pull request
Nov 15, 2022
Dplane sorry (backport #12315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.