Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zebra sometimes does not connect to FPM #12314

Closed
1 of 2 tasks
stepanblyschak opened this issue Nov 14, 2022 · 0 comments
Closed
1 of 2 tasks

Zebra sometimes does not connect to FPM #12314

stepanblyschak opened this issue Nov 14, 2022 · 0 comments
Labels
triage Needs further investigation

Comments

@stepanblyschak
Copy link


Describe the bug

We are switching from using old fpm plugin to new dplane_fpm_nl plugin and observe that sometimes zebra does not connect to fpm server.

The configuration in /etc/frr/zebra.conf is the following:

frr@5beef0983ab7:/$ cat /etc/frr/zebra.conf
log stdout debugging
debug zebra fpm
no fpm use-next-hop-groups
fpm address 127.0.0.1

I start zebra:

/usr/lib/frr/zebra -A 127.0.0.1 --asic-offload=notify_on_offload -M dplane_fpm_nl

I start fpm-stub from https://github.com/donaldsharp/fpm-stub/tree/return_static:

Reflecting some routes with OFFLOAD flag set
Waiting for client connection...

But fpm-stub stucks at waiting for client connection. This issues happens once out of 3 retries.

Important note, if I remove the line no fpm use-next-hop-groups from zebra.conf the issue is not reproducible.

  • Did you check if this is a duplicate issue?
  • Did you test it on the latest FRRouting/frr master branch?

To Reproduce

Expected behavior

I expect zebra connects to FPM application.

Screenshots

Versions

  • OS Version: Ubuntu 20.04.5 LTS
  • Kernel: 4.15.0-130-generic
  • FRR Version: 8.5-dev (5f37d59 + PR 12075)

Additional context

@stepanblyschak stepanblyschak added the triage Needs further investigation label Nov 14, 2022
mergify bot pushed a commit that referenced this issue Nov 15, 2022
If you have this order in your configuration file:

no fpm use-next-hop-groups
fpm address 127.0.0.1

the dplane code was using the same event thread t_event and the second
add event in the code was going, you already have an event scheduled
and as such the second event does not overwrite it.  Leaving
no code to actually start the whole processing.  There are probably
other cli iterations that will cause this fun as well, but I'm
not going to spend the time sussing them out at the moment.

Fixes: #12314
Signed-off-by: Donald Sharp <[email protected]>
(cherry picked from commit 551fa8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs further investigation
Projects
None yet
Development

No branches or pull requests

1 participant