Leaderboard dates using format and language #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
requested changes
May 28, 2024
…rboard-dates-using-format-and-language
Sheikah45
requested changes
May 29, 2024
…ariable members to TimeService, fixed access mode
Sheikah45
approved these changes
May 29, 2024
BlackYps
reviewed
May 29, 2024
Comment on lines
+3
to
+4
| <option name="ALTERNATIVE_JRE_PATH" value="temurin-21" /> | ||
| <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" /> |
There was a problem hiding this comment.
Is this supposed to be here?
There was a problem hiding this comment.
It just specifies the jre for the run config if someone doesn't have it set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for an issue - #3176
Description
Took simpler approach, there are still functions that could be also refactored(DateTime), but would require more boiler plate code of how should specific format look like. Moreover Added support only for Short, Medium and Long style of Date
Test