Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date language mixup #3176

Closed
Backspace345 opened this issue May 22, 2024 · 9 comments
Closed

Date language mixup #3176

Backspace345 opened this issue May 22, 2024 · 9 comments
Labels

Comments

@Backspace345
Copy link

Backspace345 commented May 22, 2024

Describe the bug
In leaderboards tab the current season period is shown in French, while client language is set to English. Changing client language doesn't change date language in leaderboards. Date format in settings is set to Day/Month/Year, if that's related.

To Reproduce
Go to settings > appearance, set date format to Day/Month/Year, go to Leaderboards tab.

Expected behavior
Dates changing according to client language.

Screenshots
1

OS
Windows 10

@Sheikah45
Copy link
Member

This is an artifact of the time locale being able to be set independently of the language in settings.

@magge-faf
Copy link
Collaborator

FYI: In the context of 'mai', 'juin' is most likely French.

@Backspace345
Copy link
Author

FYI: In the context of 'mai', 'juin' is most likely French.

Thanks! Post updated

@sulikdan
Copy link
Contributor

@Sheikah45 Were you able to reproduce it by description? I tried to look into, but the date is following a user's setting of preferred language. Tried multiple combination.

@Backspace345 If you change a language(to somethign different) and restart the client, is it still same? Do you still get french one? Even when you get back to origin language?

Tested on Win11.

@Backspace345
Copy link
Author

@sulikdan yes, tried multiple times now, for some reason it just stays there. Complete reinstall removed the bug though. I wonder if it's because my windows install broke once. Due to that i had to reformat drive with it, which apparently contained some of the metadata client files, but the client itself was installed on a separate drive, and after reinstalling windows i just went to the client folder and created a shortcut manually. Surprisingly enough it worked just fine. So i guess there never was any issue?

@Sheikah45
Copy link
Member

Yes it is because of this setting being not auto
image

@Backspace345
Copy link
Author

Backspace345 commented May 26, 2024

Yes it is because of this setting being not auto image

Can confirm, this is what causing it. Surprisingly setting date format to Month/Day/Year doesn't do it. Post updated

@sulikdan
Copy link
Contributor

@Sheikah45 can I take it?

@Sheikah45
Copy link
Member

In terms of fixing it sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants