-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "git describe" to display a nice rev-number #87
Comments
50 is the number of commits since tag 0.1 What do you think about adding some pre-compile step that writes this in a file for include? |
Well, hash tail is ugly but descriptive (makes easier to find the right tree here), but I have no preference though. |
Feedback welcome (and updates to cmake + automake to invoke revision.sh) |
"Looks legit, however in my opinion tagged (official) source packages, e.g. easyrpg-player-0.1-src.tar.gz should include pregenerated revision.h by default and not depend on git usage." Simple heuristic: Don't write file when .git is missing and revision.h exists. |
@Lobomon
(this should become a part of the android build script later) |
For non-win32 ports, configure.ac and CMakeLists.txt has a builtin version number macro, doing a sed replacing for these on Jenkins jobs will generate a version define (autotools adds these defines to config.h). These can be patched before calling ./configure or cmake. configure.ac and CMakeLists.txt standard define name for versioning is PACKAGE_VERSION |
Considering we are full CMake and Autotools now it should be finally possible to add this without toooo much afford? See also #2070 |
After creating our first tag (0.1) "git describe" can be used to get a more readable revision number 0.1-### (where ### is the number of commits since 0.1).
The output of "git describe" should be written in some header file and then be included by player and e.g. displayed in the title bar.
This makes it easier for us to figure out which version somebody uses (Maybe also write it in the PNG-tEXT chunk under "Software" if he used our screenshot function and we cant see the title bar). And to detect if somebody made local changes (e.g. by adding an 'M' after the rev number)
The text was updated successfully, but these errors were encountered: