Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip *.script.wav files from Ineluki's Key Patch #731

Closed
carstene1ns opened this issue Jan 19, 2016 · 0 comments
Closed

Skip *.script.wav files from Ineluki's Key Patch #731

carstene1ns opened this issue Jan 19, 2016 · 0 comments
Milestone

Comments

@carstene1ns
Copy link
Member

Currently, the log is spammed with

[2016-01-19 13:36:50] Warning: Couldn't load MidiTickOutput.script SE.
Unrecognized sound file type
[2016-01-19 13:36:50] Warning: Couldn't load KeyList.script SE.
Unrecognized sound file type
[2016-01-19 13:36:50] Warning: Couldn't load KeySupportOn.script SE.
Unrecognized sound file type
[2016-01-19 13:36:51] Warning: Couldn't load MidiTickOutput.script SE.
Unrecognized sound file type
[2016-01-19 13:36:51] Warning: Couldn't load KeyList2.script SE.
Unrecognized sound file type
[2016-01-19 13:36:51] Warning: Couldn't load KeySupportOn.script SE.
Unrecognized sound file type
[2016-01-19 13:36:51] Warning: Couldn't load MidiTickClear.script SE.

It is because the sound effects are used as triggers for scripts. While we cannot easily support the whole key patch (maybe we could write some - likely game specific - key wrapper logic after #491 is implemented), we should at least give a better message and only display it once per game launch.

This could be done like the infamous '(Brak)' check, "if SE ends with .script", then set a flag and display:
"Warning: Game uses Ineluki's Key patch, additional keys and scripts will not work!"

Besides the additional keys, this patch adds mouse support (was this even used by a popular game?)
and a buggy mp3 support (through *.link.wav files like disharmony? - not worth it)


An example game using this patch is "Harvest Moon - Mondlichts Kinder", issue reported by mail.

@Ghabry Ghabry modified the milestone: 0.5.0 Feb 19, 2016
carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue Feb 29, 2016
fdelapena added a commit that referenced this issue Mar 4, 2016
@Ghabry Ghabry modified the milestones: 0.4.1, 0.5.0 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants