-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large CharSet support ($CharSet) doesn't work properly on looping maps #3149
Comments
Found a solution for the complete disappearing of the charset. Patch follows next week, code currently too ugly 😅 This will not solve the Z order "issue" (depending on your location other events are drawn above or below the large charset) but this isn't really solvable due to how charset rendering order works. So that part is Won't Fix/Not a bug. (the lack of transparency is because the program I used to rescale messed up the color palette) |
Correction: I found the reason why the z order changes, so this is also looking good now and they stay the same priority :) (at least when testing on that simple map here). before.webmafter.webm |
The change doubles the amount of sprites on looping maps but this fixes all the rendering issues, especially with big charsets ($). Most of the sprites are culled because they are out of bounds on larger maps, so the performance implications are small. Fix EasyRPG#3149
The change doubles the amount of sprites on looping maps but this fixes all the rendering issues, especially with big charsets ($). Most of the sprites are culled because they are out of bounds on larger maps, so the performance implications are small. Fix EasyRPG#3149
The change doubles the amount of sprites on looping maps but this fixes all the rendering issues, especially with big charsets ($). Most of the sprites are culled because they are out of bounds on larger maps, so the performance implications are small. Fix EasyRPG#3149
The change doubles the amount of sprites on looping maps but this fixes all the rendering issues, especially with big charsets ($). Most of the sprites are culled because they are out of bounds on larger maps, so the performance implications are small. Fix EasyRPG#3149
The change doubles the amount of sprites on looping maps but this fixes all the rendering issues, especially with big charsets ($). Most of the sprites are culled because they are out of bounds on larger maps, so the performance implications are small. Fix EasyRPG#3149
Player platform:
Windows, 64 bits continuous build of the Player.
Describe the issue in detail and how to reproduce it:
Create an horizontal looping map and place an event randomly in it. Use a graphic for its CharSet starting with the character $, and make it have a huge size in length (e.g. 1000% of a normal CharSet).
Example with this version of the EasyRPG RTP CharSet
Actor1
, named here$Actor1
.While in-game, if you are standing at the right of the event, you should notice that the event will not be displayed if the vertical line on its right is not displayed on the screen.
Here, the player is on the right of the event and the event is on-screen; the event is displayed:
Here, the player is on the right of the event, but the event is not on-screen; only the vertical line on the right of the event is displayed on-screen, so the event is still displayed:
Here, the player is on the right of the event, but the event is not on-screen and the vertical line on its right is not on-screen; the event is not displayed on-screen:
There is no such issue with the left side.
Another thing to note is that a big vertical CharSet can overlap differently depending on where you are located on the map, though it may not be a huge issue if said event is overlapping itself since I don't think that a lot of users would try that.
The text was updated successfully, but these errors were encountered: