Moved 'imminent collision' state

[m4gr3d]

Moved imminent collision state from the drone State to its Altitude.

[Thalek]

Observation: "imminent crash" would certainly belong in "Altitude", as far as nomenclature is concerned. But you've changed the name from "Imminent Crash" to "Imminent Collision" as a prelude to implementing collision detection and avoidance. Once that progresses further, will "Altitude" still be the appropriate place for those functions?

[arthurbenemann]

@Thalek its more of a concern of software architecture than nomenclature (names are easy to change). The idea here is to move the method to the class the contain the most fields it needs to acess , thus reducing dependencies and coupling of multiple classes.

[Thalek]

Thank you for the clarification, Arthur.

I presume this class is anticipated to still be the best choice when more complicated collision/avoidance software is developed.

I really wish I knew enough programming to offer more than the occasional semi-informed comment. [wry smile]

[squilter]

@Thalek you're completely right. In a few years the collision detector will be implemented in flight code and it will be able to detect more than just altitude-related collisions. But that's still years away and we can just move it later.

[Thalek]

Thank you, Squilter.