Added crash alert. beep beep #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public void onDroneEvent(DroneInterfaces.DroneEventsType event, Drone drone) { | ||
| if(event.equals(DroneInterfaces.DroneEventsType.STATE)){ |
There was a problem hiding this comment.
@TShapinsky DroneEventsType is an enum, so you can use event == DroneEventsType.STATE instead of using the equals() method.
|
@TShapinsky looks good. Any one up for testing that feature with their drone :D |
|
thanks @ne0fhyk i made some revisions based off of your input. I'm also thinking about adding an option but im not sure if its something we want people to be able to turn off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature probably wont stop many crashes but it is the first iteration of collision detection. Hopefully this can spark a conversation about serious collision detection and avoidance.
closes #1006