Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #82 -- Improved the chapter on dictionaries. #107

Merged
merged 1 commit into from
Aug 10, 2014

Conversation

bmispelon
Copy link
Contributor

Thanks to @kerstin for the feedback.

@@ -220,26 +220,39 @@ You can find a list of all available list methods in this chapter of the Python

## Dictionaries

A dictionary is similar to a list, but you access values by looking up a key instead of an index. A key can be any string or number. The syntax to define a dictionary is:
A dictionary is similar to a list, but you access values by looking up a key instead of an index. A key can be any string or number. The syntax to define a empty dictionary is:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be: an empty dictionary

@olasitarska
Copy link
Member

I added some feedback here. Do you mind fixing?:)

@bmispelon
Copy link
Contributor Author

Of course not, I'll fix it as soon as I'm back at the computer.

Thanks!
On Aug 9, 2014 12:44 PM, "Ola Sitarska" [email protected] wrote:

I added some feedback here. Do you mind fixing?:)


Reply to this email directly or view it on GitHub
#107 (comment).

@bmispelon
Copy link
Contributor Author

@olasitarska: I fixed all the mistakes you found, thanks.

@oinopion @kerstin: Does that look good? Is there something else I could address in this PR?

@olasitarska
Copy link
Member

@bmispelon thanks! ready to be merged for me, but let's hear from @oinopion and @kerstin :)

@keikoro
Copy link

keikoro commented Aug 10, 2014

Looking goooooooooood! Thanks so much for the improvement, @bmispelon. ((:

olasitarska added a commit that referenced this pull request Aug 10, 2014
Fixed #82 -- Improved the chapter on dictionaries.
@olasitarska olasitarska merged commit 98e4423 into DjangoGirls:master Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants