Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added part on dictionaries (Intro to Python chapter) #82

Closed
keikoro opened this issue Jul 27, 2014 · 4 comments
Closed

Newly added part on dictionaries (Intro to Python chapter) #82

keikoro opened this issue Jul 27, 2014 · 4 comments

Comments

@keikoro
Copy link

keikoro commented Jul 27, 2014

Just went looking at the newly added part in the intro chapter (dictionaries, see #77) to check for mistakes and wanted to ask: does anyone mind if I replace the example (django "dolls") with something else?

I was actually a little confused at first - I thought "dolls" (which is sometimes used a little condescendingly) was used instead of "girls" so as not to be too repetitive - but even now that I've realised that it refers indeed to toy dolls, it seems a little... off, especially considering that the tutorial isn't aimed at little girls but adult women mostly.

@oinopion
Copy link
Contributor

I think it's best to replace this with something completely neutral. Also this example does not a good job at showing usefulness of dicts. How about this

addresses = {'github': 'https://github.com', 'google': 'https://google.com'}

This at least shows why you would use it.

@keikoro
Copy link
Author

keikoro commented Jul 27, 2014

Yup, something neutral is much better. (: Currently cleaning up the introduction to the command line chapter but will come back to this later.

(And ahh, I generally thought that adding dictionaries too might be a bit much but then again they do fit with the topic of lists.)

@keikoro
Copy link
Author

keikoro commented Jul 29, 2014

Just adding that anyone who wants to do / has time to do this is very welcome to. Prolly won't be able to pick this up again for a few days...

bmispelon added a commit to bmispelon/tutorial that referenced this issue Aug 9, 2014
@bmispelon
Copy link
Contributor

Tried my hand at it in #107

Feedback welcome!

olasitarska added a commit that referenced this issue Aug 10, 2014
Fixed #82 -- Improved the chapter on dictionaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants