Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Rust 2018 #72

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Migrate to Rust 2018 #72

merged 1 commit into from
Jan 8, 2021

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Nov 9, 2020

Since #69, the minimum Rust version supported by this crate is 1.36 (because nix 0.18 use std::mem::MaybeUninit that stabilized in 1.36), so we can migrate to the 2018 edition without breakage.

(This patch was created primarily by running cargo fix --editon, removing needless extern crate, and removing self:: prefix from external crate paths.)

@taiki-e
Copy link
Contributor Author

taiki-e commented Nov 9, 2020

CI failure seems unrelated:
https://ci.appveyor.com/project/Detegr/rust-ctrlc/builds/36213138/job/n7075os1fgg4ukqa:

warning: spurious network error (2 tries remaining): error inflating zlib stream; class=Zlib (5)
warning: spurious network error (1 tries remaining): error inflating zlib stream; class=Zlib (5)
error: failed to get `nix` as a dependency of package `ctrlc v3.1.7 (C:\projects\rust-ctrlc)`

https://ci.appveyor.com/project/Detegr/rust-ctrlc/builds/36213138/job/35bvkdof3savoyf7:

warning: spurious network error (2 tries remaining): error inflating zlib stream; class=Zlib (5)
warning: spurious network error (1 tries remaining): error inflating zlib stream; class=Zlib (5)
error: failed to get `nix` as a dependency of package `ctrlc v3.1.7 (C:\projects\rust-ctrlc)`

@Detegr Detegr merged commit dedc984 into Detegr:master Jan 8, 2021
@Detegr
Copy link
Owner

Detegr commented Jan 8, 2021

Thank you. Excellent explanation of how this should be safe to do without breakages.

@taiki-e taiki-e deleted the rust-2018 branch January 8, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants