Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nix to 0.18 #69

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Update nix to 0.18 #69

merged 1 commit into from
Oct 11, 2020

Conversation

printfn
Copy link
Contributor

@printfn printfn commented Oct 1, 2020

pipe2 is no longer available on macOS, so I implemented it manually using pipe and fcntl similar to how it was implemented in nix 0.17.

@tommythorn
Copy link

I can confirm that this also fixes #70, which is required to fix http. Can we merge this please?

@Detegr
Copy link
Owner

Detegr commented Oct 11, 2020

What the... Apple has removed pipe2?
We can absolutely merge this, thanks for contributing!

@Detegr Detegr merged commit c7ad296 into Detegr:master Oct 11, 2020
@taiki-e taiki-e mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@printfn @tommythorn @Detegr