Added basic VolumeManager support #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TO-DO: Load default values for PPPasses for blending TO-DO: Add support for ToonRP Passes to support volumes
Delt06
requested changes
Jul 9, 2024
Assets/Samples/Volume Framework/Scripts/ToonSharpenVolumeComponent.cs
Outdated
Show resolved
Hide resolved
Packages/com.deltation.toon-rp/Runtime/ToonAdditionalCameraData.cs
Outdated
Show resolved
Hide resolved
Packages/com.deltation.toon-rp/Runtime/ToonAdditionalCameraData.cs
Outdated
Show resolved
Hide resolved
Packages/com.deltation.toon-rp/Runtime/ToonAdditionalCameraData.cs
Outdated
Show resolved
Hide resolved
Delt06
requested changes
Jul 14, 2024
Packages/com.deltation.toon-rp/Runtime/PostProcessing/ToonPostProcessingPassAsset.cs
Outdated
Show resolved
Hide resolved
Assets/Samples/Volume Framework/Scripts/ToonSharpenVolumeComponent.cs
Outdated
Show resolved
Hide resolved
Converted: Sharpen, ToneMapping, FilmGrain, Bloom, Vignette
Added: - ScreenSpace Outlines - Lookup Table - Motion blur Minor fixes for other stacks
Delt06
requested changes
Jul 14, 2024
...ages/com.deltation.toon-rp/Runtime/PostProcessing/BuiltIn/ToonScreenSpaceOutlineComponent.cs
Outdated
Show resolved
Hide resolved
...ages/com.deltation.toon-rp/Runtime/PostProcessing/BuiltIn/ToonScreenSpaceOutlineComponent.cs
Show resolved
Hide resolved
...ages/com.deltation.toon-rp/Runtime/PostProcessing/BuiltIn/ToonScreenSpaceOutlineComponent.cs
Outdated
Show resolved
Hide resolved
Delt06
approved these changes
Jul 15, 2024
Delt06
requested changes
Jul 15, 2024
Packages/com.deltation.toon-rp/Runtime/PostProcessing/ToonBuiltinVolumeComponentContainer.cs
Outdated
Show resolved
Hide resolved
Delt06
requested changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for Unity's VolumeFramework system. This allows users to build their own effects or volume integrations within ToonRP.
TO-DO: Add volume support to built-in ToonRP Passes
TO-DO: Pass default values from PostProcessingPass to VolumeManager