Allow users to configure capture metrics expiration #1150
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blt
force-pushed
the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
2 times, most recently
from
48ad9c8 to
2d6266e
Compare
blt
force-pushed
the
blt/allow_users_to_configure_capture_metrics_expiration
branch
from
bb2654c to
fc18f28
Compare
GeorgeHahn
reviewed
Dec 14, 2024
| @@ -80,6 +86,9 @@ pub enum Telemetry { | |||
| path: PathBuf, | |||
| /// Additional labels to include in every metric | |||
| global_labels: FxHashMap<String, String>, | |||
| /// The time metrics that have not been written to will take to expire. | |||
| #[serde(default = "default_expiration")] | |||
| expiration: Duration, | |||
There was a problem hiding this comment.
metrics_expiration maybe?
GeorgeHahn
approved these changes
Dec 14, 2024
blt
force-pushed
the
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
branch
from
2d6266e to
9c62ec8
Compare
blt
force-pushed
the
blt/allow_users_to_configure_capture_metrics_expiration
branch
from
fc18f28 to
205840e
Compare
blt
changed the base branch from
blt/ensure_cgroup_cpu_poller_works_with_multiple_cgroups
to
graphite-base/1150
This commit adjusts the capture metrics expiration so that it is by default Duration::MAX and is a configurable setting. In the future we will bring this value down, but this preserves behavior between lading releases while still allowing for new capability. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/allow_users_to_configure_capture_metrics_expiration
branch
from
205840e to
5db5634
Compare
blt
force-pushed
the
graphite-base/1150
branch
from
9c62ec8 to
4191cbb
Compare
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/allow_users_to_configure_capture_metrics_expiration
branch
from
5db5634 to
05d2855
Compare
Merge activity
|
blt
deleted the
blt/allow_users_to_configure_capture_metrics_expiration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adjusts the capture metrics expiration so that it is by
default Duration::MAX and is a configurable setting. In the future we
will bring this value down, but this preserves behavior between lading
releases while still allowing for new capability.