Don't coerce counters to floats, avoid metrics handles #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
changed the base branch from
blt/introduce_k8s_style_millicore_cpu_data
to
graphite-base/1144
blt
force-pushed
the
graphite-base/1144
branch
from
04ee833 to
f503e5b
Compare
blt
force-pushed
the
blt/don_t_coerce_counters_to_floats_avoid_metrics_handles
branch
from
e5d9e60 to
412e106
Compare
blt
force-pushed
the
blt/don_t_coerce_counters_to_floats_avoid_metrics_handles
branch
from
412e106 to
39e72c5
Compare
GeorgeHahn
approved these changes
Dec 12, 2024
This commit corrects a bug where counter values -- integer -- were converted to floats leading to odd capture data. I have also adjusted our use of metrics to always use the macro, avoiding metric handles that might cause a metric to not expire when it should. On this last point I have only audited the generators. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/don_t_coerce_counters_to_floats_avoid_metrics_handles
branch
from
39e72c5 to
eb38edd
Compare
Signed-off-by: Brian L. Troutwine <[email protected]>
This was referenced Dec 12, 2024
blt
deleted the
blt/don_t_coerce_counters_to_floats_avoid_metrics_handles
branch
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit corrects a bug where counter values -- integer -- were
converted to floats leading to odd capture data. I have also adjusted
our use of metrics to always use the macro, avoiding metric handles
that might cause a metric to not expire when it should.