Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some specific furnitures/terrains examine as always allowed in faction territory #78631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RenechCDDA
Copy link
Member

Summary

Bugfixes "Mark some specific furnitures/terrains examine as always allowed in faction territory"

Purpose of change

Describe the solution

Add a flag FREE_TO_EXAMINE to the common furniture/terrain that should always be examinable.

If that flag is present, the locals will never care about you examining it.

Added to the following furniture/terrain:
Translocator (magiclysm)
Exodii sign at their main base and all other f_sign by extension
Exodii sign at their barns (not faction territory atm, but just in case)

Describe alternatives you've considered

Tying it to the examine actor/function

Uh it turns out that a flag was incredibly simple, so the flag was chosen instead.

Testing

Spawned a sign at a faction territory

Examined glass display case, got warned

Examined sign, no warning

Additional context

#77239 (comment) is a problem with the design. There's no way in and the prisoners SHOULD be upset about you forcing your way in (they're barricaded to keep the zombies out). I don't know what to do there 🤷

This PR was way easier than I thought.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 17, 2024
@github-actions github-actions bot requested a review from KorGgenT December 17, 2024 21:40
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Stealing" checks are too aggressive
1 participant